refactor: change error definition in feature PKG to Bucketeer error - #2120
Merged
Conversation
# Conflicts: # pkg/error/error.go
kakcy
marked this pull request as ready for review
September 11, 2025 09:15
# Conflicts: # pkg/api/api/grpc_status.go # pkg/error/error.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors error handling in the feature API to use a centralized error definition and conversion approach, improving consistency and maintainability. The main changes include replacing direct gRPC status construction with error objects from the core error package, introducing a new error type for failed preconditions, and updating how errors are converted to gRPC status codes and messages.