refactor: change error definition in experiment PKG to Bucketeer error - #2124
Merged
Conversation
# Conflicts: # pkg/error/error.go
# Conflicts: # pkg/error/error.go
kakcy
marked this pull request as ready for review
September 16, 2025 07:59
# Conflicts: # pkg/error/error.go
# Conflicts: # pkg/experiment/api/api.go # pkg/experiment/api/experiment.go # pkg/experiment/api/goal.go # pkg/experiment/domain/experiment.go # pkg/experiment/storage/v2/experiment.go
# Conflicts: # pkg/error/error.go
Contributor
Author
|
@nnnkkk7 |
nnnkkk7
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors error handling in the experiment service by standardizing gRPC status creation and error responses. Instead of manually constructing detailed error responses throughout the code, it now leverages a centralized error utility, resulting in cleaner, more maintainable, and consistent error handling. The changes affect both experiment and goal-related APIs.
I have also standardized the process of assigning ErrorInfo to GRPCStatus for each error via
api.NewGRPCStatus.This
ErrorInfowill be used when moving i18n to the frontend(#1253), and we plan to generate error messages etc. based on this information on the frontend.