chore: remove old console - #2126
Merged
Merged
Conversation
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
steveninhle
self-requested a review
September 22, 2025 04:59
nnnkkk7
reviewed
Sep 22, 2025
| webConsoleServer := rest.NewServer( | ||
| *s.certPath, *s.keyPath, | ||
| rest.WithLogger(logger), | ||
| rest.WithPort(*s.webConsoleServicePort), |
Contributor
There was a problem hiding this comment.
Please also remove webConsoleServicePort itself🙏
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
nnnkkk7
reviewed
Sep 22, 2025
Contributor
There was a problem hiding this comment.
You might want to remove this file👀
Signed-off-by: Alessandro Yuichi Okimoto <yuichijpn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2127
This PR removes the old console and its references.