Skip to content

ci: fix evaluation ts publish with Node.js 22 - #2759

Merged
cre8ivejp merged 4 commits into
mainfrom
fix-evaluation-node22
Aug 7, 2026
Merged

ci: fix evaluation ts publish with Node.js 22#2759
cre8ivejp merged 4 commits into
mainfrom
fix-evaluation-node22

Conversation

@cre8ivejp

@cre8ivejp cre8ivejp commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

  • use Node.js 22 for package compatibility
  • allow non-main runs when dry_run is enabled
  • keep the publishing workflow simple with one job

Test plan

  • Validate workflow syntax and formatting
  • Run from main with dry_run enabled and a branch in checkout_ref
  • Merge and publish @bucketeer/evaluation@0.0.9

cre8ivejp and others added 2 commits August 7, 2026 12:05
Use a runtime supported by both npm trusted publishing and the package's AVA dependency.

Co-authored-by: Cursor <cursoragent@cursor.com>
Allow testing another ref without granting the dry-run job an npm OIDC publishing token.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI review requested due to automatic review settings August 7, 2026 03:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TypeScript evaluation package publishing workflow to use Node.js 22 and to better separate dry-run verification from real npm OIDC publishing, with accompanying documentation updates for testing other refs.

Changes:

  • Switch publishing workflow to Node.js 22 (npm/AVA compatibility).
  • Add checkout_ref input and a dedicated dry-run job to verify a branch/tag/SHA without npm OIDC permissions.
  • Document how to dry-run another ref in the evaluation TypeScript README.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
evaluation/typescript/README.md Documents using checkout_ref + dry_run (run from main) to verify other refs.
.github/workflows/publish-evaluation-ts.yaml Moves to Node 22, adds checkout_ref, splits dry-run vs publish to isolate OIDC permissions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/publish-evaluation-ts.yaml Outdated
cre8ivejp and others added 2 commits August 7, 2026 12:16
Allow the tokenless dry-run job to execute outside main while keeping real npm publishing restricted to main.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep one publishing job and allow non-main execution only when the dry-run input is enabled.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cre8ivejp cre8ivejp changed the title fix(evaluation): publish with Node.js 22 ci: fix evaluation ts publish with Node.js 22 Aug 7, 2026
@cre8ivejp
cre8ivejp marked this pull request as ready for review August 7, 2026 03:22
@cre8ivejp
cre8ivejp merged commit 3629edc into main Aug 7, 2026
14 checks passed
@cre8ivejp
cre8ivejp deleted the fix-evaluation-node22 branch August 7, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants