Skip to content

fix(flaky test): use proto.Equal for gRPC status comparison in TestUpdateFeature #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-kikuc merged 2 commits into from
Aug 14, 2026
Merged

fix(flaky test): use proto.Equal for gRPC status comparison in TestUpdateFeature #2774

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06968ce
fix: use proto.Equal for gRPC status comparison in TestUpdateFeature
t-kikuc Aug 14, 2026
85dedfa
fix: unpack Any details before proto.Equal comparison
t-kikuc Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/feature/api/feature_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"google.golang.org/grpc/codes"
"google.golang.org/grpc/metadata"
"google.golang.org/grpc/status"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/types/known/wrapperspb"

"github.com/bucketeer-io/bucketeer/v2/pkg/api/api"
Expand Down Expand Up @@ -3206,7 +3207,15 @@ func TestUpdateFeature(t *testing.T) {
p.setup(service)
}
_, err := service.UpdateFeature(p.ctx, p.input)
assert.Equal(t, p.expectedErr, err)
if p.expectedErr == nil {
assert.NoError(t, err)
} else {
require.Error(t, err)
expectedSt, _ := status.FromError(p.expectedErr)
actualSt, _ := status.FromError(err)
assert.True(t, proto.Equal(expectedSt.Proto(), actualSt.Proto()),
"expected status %v, got %v", expectedSt.Proto(), actualSt.Proto())
Comment thread
t-kikuc marked this conversation as resolved.
Outdated
}
})
}
}
Loading