feat: support redis TLS - #2777
Open
Ubisoft-potato wants to merge 5 commits into
Open
Conversation
hvn2k1
requested
a balanced review from Copilot
and removed request for
Copilot
August 18, 2026 07:32
Ubisoft-potato
marked this pull request as ready for review
August 18, 2026 10:13
Ubisoft-potato
requested review from
cre8ivejp,
hvn2k1 and
t-kikuc
as code owners
August 18, 2026 10:13
There was a problem hiding this comment.
Pull request overview
Adds Redis/Valkey TLS support across services and Helm deployments.
Changes:
- Adds reusable Redis TLS configuration with CA and mTLS support.
- Exposes service CLI flags and Helm values for Redis TLS.
- Propagates TLS settings to subscriber configurations and mounts certificate secrets.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pkg/redis/v3/redis.go |
Implements Redis TLS configuration. |
pkg/redis/v3/redis_test.go |
Tests TLS configuration handling. |
pkg/api/cmd/server.go |
Configures API Redis TLS. |
pkg/batch/cmd/server/server.go |
Configures batch Redis TLS. |
pkg/subscriber/subscriber.go |
Adds subscriber TLS fields. |
pkg/subscriber/cmd/server/server.go |
Configures subscriber Redis TLS. |
pkg/web/cmd/server/server.go |
Configures web Redis TLS. |
manifests/bucketeer/values.yaml |
Defines shared PubSub TLS values. |
manifests/bucketeer/charts/api/values.yaml |
Defines API TLS values. |
manifests/bucketeer/charts/api/templates/deployment.yaml |
Injects API TLS settings and secret. |
manifests/bucketeer/charts/batch/values.yaml |
Defines batch TLS values. |
manifests/bucketeer/charts/batch/templates/deployment.yaml |
Injects batch TLS settings and secret. |
manifests/bucketeer/charts/subscriber/values.yaml |
Defines subscriber TLS values. |
manifests/bucketeer/charts/subscriber/templates/deployment.yaml |
Injects subscriber TLS settings and secret. |
manifests/bucketeer/charts/subscriber/templates/subscribers-configmap.yaml |
Propagates PubSub TLS configuration. |
manifests/bucketeer/charts/web/values.yaml |
Defines web TLS values. |
manifests/bucketeer/charts/web/templates/deployment.yaml |
Injects web TLS settings and secret. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
# Conflicts: # pkg/api/cmd/server.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds TLS support for Redis/Valkey connections across all four services (api, batch, subscriber, web). Bucketeer previously could only connect to Redis in plaintext, which is incompatible with AWS ElastiCache/MemoryDB deployments that have in-transit encryption enabled.
pkg/redis/v3: newTLSConfig+WithTLSoption. Builds a standardtls.Config—CACert(optional, defaults to the system CA pool, sufficient for AWS ElastiCache/MemoryDB),Cert/Key(optional, for mutual TLS against self-managed Redis/Valkey that enforces client certs — not supported by AWS-managed Redis), andInsecureSkipVerify(dev/testing only).api,batch,subscriber, andwebgets matching*-tls-enabled/-ca-cert/-cert/-key/-insecure-skip-verifyCLI flags (env-var bound via kingpin), independently configurable per Redis block (main/persistent/non-persistent/pubsub) since some deployments mix a TLS-enabled primary Redis with a plaintext pubsub Redis, etc.pubsub.redisTLS fields (including a newtlsSecretName) live once at the top level and are referenced by all four charts. WhentlsSecretNameis set, all fourdeployment.yamls mount that secret read-only at/usr/local/certs/redis, mirroring the existing PostgressslSecretNamepattern. Leaving it unset (default) renders no volume/mount at all.subscribers-configmap.yamlpropagates the pubsub Redis TLS settings intosubscribers.json,onDemandSubscribers.json, and thesegmentUserPersisterblock ofprocessors.json.Scope notes
redis:7-alpineimage doesn't support TLS termination, andtlsEnabledis more meaningfully exercised against a real TLS endpoint (ElastiCache/MemoryDB or self-hosted). This mirrors the existing Postgres TLS precedent's config surface but not its local end-to-end termination.Closes #2771