feat(ui/dashboard): show selected user segments in a popover - #2785
Merged
Conversation
steveninhle
marked this pull request as ready for review
August 26, 2026 02:46
steveninhle
requested review from
cre8ivejp,
hvn2k1 and
t-kikuc
as code owners
August 26, 2026 02:46
There was a problem hiding this comment.
Pull request overview
Replaces the expanded selected-segment list with a compact popover.
Changes:
- Adds a selected-segment count trigger and popover.
- Supports removing segments from the popover.
- Adds English and Japanese count translations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
rule-clauses-form/index.tsx |
Adds the segment popover UI. |
@locales/en/common.json |
Adds English count labels. |
@locales/ja/common.json |
Adds Japanese count labels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ui/dashboard/src/elements/rule-clauses-form/index.tsx:595
- This icon-only removal button has no accessible name, so screen-reader users cannot identify its action or which segment it removes. Add a localized
aria-labelthat includesitem.name(for example, “Remove {{name}}”).
<button
type="button"
steveninhle
force-pushed
the
feat/rule-clauses-segments-popover
branch
from
August 28, 2026 07:40
0873861 to
7afcdd2
Compare
steveninhle
force-pushed
the
feat/rule-clauses-segments-popover
branch
from
August 28, 2026 09:59
7afcdd2 to
1173c24
Compare
t-kikuc
reviewed
Aug 31, 2026
t-kikuc
reviewed
Aug 31, 2026
steveninhle
force-pushed
the
feat/rule-clauses-segments-popover
branch
from
August 31, 2026 08:16
1173c24 to
fbddd05
Compare
t-kikuc
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuleClausesForm (shared by Feature Flag Details → Targeting rules) showed every selected user segment as an always-expanded list of links under the segment dropdown, which took up a lot of vertical space when many segments were selected.
Replaced the inline list with a compact "N user segments selected" trigger that opens a popover listing the segments