test: clear non-production CodeQL findings - #307
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why the exclusion is narrow
The remaining DOM XSS result is in an immutable historical widget fixture used for compatibility testing. Editing it would invalidate the fixture. The CodeQL config excludes only
test/fixtures/legacy-compat/**; a repository guard rejects broader exclusions.Validation
make checknpm test— 70 files, 990 testsnpx vitest run test/liveConsoleErrors.test.ts— 9 testsbash test/security-analysis-workflows.test.shactionlint .github/workflows/codeql.ymlThe first full test attempt had three 5-second timeouts in
retention-integration.test.ts; that file passed 8/8 in isolation and the repeated full suite passed 990/990.