Skip to content

test: clear non-production CodeQL findings - #307

Merged
neonwatty merged 1 commit into
mainfrom
codex/triage-codeql-test-findings
Aug 8, 2026
Merged

neonwatty merged 1 commit into
mainfrom
codex/triage-codeql-test-findings

Conversation

@neonwatty

Copy link
Copy Markdown
Collaborator

Summary

  • replace the incomplete Google Fonts substring filter with exact parsed-host matching
  • exclude only frozen legacy compatibility fixtures from JavaScript CodeQL analysis
  • lock both behaviors with adversarial unit and workflow mutation tests

Why the exclusion is narrow

The remaining DOM XSS result is in an immutable historical widget fixture used for compatibility testing. Editing it would invalidate the fixture. The CodeQL config excludes only test/fixtures/legacy-compat/**; a repository guard rejects broader exclusions.

Validation

  • make check
  • npm test — 70 files, 990 tests
  • npx vitest run test/liveConsoleErrors.test.ts — 9 tests
  • bash test/security-analysis-workflows.test.sh
  • actionlint .github/workflows/codeql.yml
  • independent correctness, tests, contracts, and simplification reviews: no findings

The first full test attempt had three 5-second timeouts in retention-integration.test.ts; that file passed 8/8 in isolation and the repeated full suite passed 990/990.

@neonwatty
neonwatty added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit 3908475 Aug 8, 2026
13 checks passed
@neonwatty
neonwatty deleted the codex/triage-codeql-test-findings branch August 8, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant