test: stabilize Radix pointer interaction coverage - #400
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.bd-trigger-labelpointer click and existing Radix outside-interaction assertionsRoot cause
The test awaited
Animation.finishedand clicked immediately. That promise can resolve before Firefox/WebKit present the finished geometry, leaving a narrow compositor/hit-test race. CI artifacts from both failures showed Playwright completed the click but the trigger remained and#titlenever appeared. Waiting for presentation frames closes that race without increasing timeouts, retrying, or callingBugDrop.open().Verification
e2e/widget.radix.spec.ts: 15/15 passed across all three enginesnpm run validate: lint, format, both TypeScript configurations, and 2,525 unit tests passednpm run knip: passed with existing configuration hints onlyisOpen()assertion was rejected because it directly proves trigger activation and made the prior failure deterministicReview note
The required Codex review helper was attempted twice with its recursion guard. Both attempts stalled after model-cache/plugin startup warnings and emitted no findings; the second was interrupted after the same condition repeated. Manual parallel review gates and the checks above completed cleanly.
Not merged.