Skip to content

Commit d3ebba0

Browse files
authored
ci: run WASIp3 threading tests against wasmtime dev (#1669)
The threading builtins are encoded with a canonical-function opcode that no released wasmtime parses yet; 46.0.1 (the shared CI pin) and 47.0.2 (latest) both reject the composed component with "invalid leading byte (0x2d) for canonical function", which has been failing the allowed-to-fail threading job on every recent CI run. wasmtime's dev build parses the encoding and the threading tests pass with it, so use it for this job until a release catches up. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
1 parent 7c48901 commit d3ebba0

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

.github/workflows/main.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,19 @@ jobs:
163163
- run: rustup target add wasm32-wasip2
164164

165165
- uses: ./.github/actions/install-wasi-sdk
166+
167+
# The threading builtins are encoded with a canonical-function opcode
168+
# newer than any released wasmtime understands (46.0.1 and 47.0.2 both
169+
# reject it with "invalid leading byte (0x2d) for canonical function"),
170+
# so this job runs wasmtime's `dev` build instead of the pinned release.
171+
# This can go back to the shared pin once a release parses the encoding.
172+
- name: Install wasmtime dev build
173+
run: |
174+
curl --retry 5 --retry-all-errors -L -o wasmtime-dev.tar.xz https://github.com/bytecodealliance/wasmtime/releases/download/dev/wasmtime-dev-x86_64-linux.tar.xz
175+
tar xJf wasmtime-dev.tar.xz
176+
echo "`pwd`/wasmtime-dev-x86_64-linux" >> $GITHUB_PATH
177+
working-directory: ${{ runner.temp }}
178+
166179
- run: |
167180
cargo run test --languages rust,c,go tests/threading \
168181
--artifacts target/artifacts \

0 commit comments

Comments
 (0)