Test the C++ generator in CI - #1331
Closed
alexcrichton wants to merge 2 commits into
Closed
Conversation
Updating CI configuration to ensure that `cpp` is listed under the languages tested.
Member
Author
|
cc @cpetig I forgot this on the initial integration and I think there may be some test failures? |
Collaborator
|
Oh, I fully concentrated on the runtime tests and neglected the codegen tests as less important, but this is is of course not true. |
Collaborator
|
First set of fixes in https://github.com/cpetig/wit-bindgen/tree/test-cpp (just opened a PR at alexcrichton#3 ) |
* fix runtime tests * fix the majority of codegen tests
This was referenced Jul 17, 2025
Collaborator
|
@alexcrichton This MR can be closed as it was merged as part of #1340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating CI configuration to ensure that
cppis listed under the languages tested.