Test the C++ generator in CI (2nd version: with more fixes included and more upstream changes) - #1340
Merged
Merged
Conversation
Updating CI configuration to ensure that `cpp` is listed under the languages tested.
* fix runtime tests * fix the majority of codegen tests
Collaborator
Author
I guess with this amount of significant effort I will introduce an "expected codegen failure" feature and mask them for now. |
Collaborator
Author
|
I just had to deploy the already existing infrastructure for expected codegen test failures, still fixing these some day would be nice 😉 |
Collaborator
Author
|
This should be ready to merge, as it successfully turns on CI testing of C++, but the remaining expected test failures require more work. |
alexcrichton
approved these changes
Jul 21, 2025
Merged
via the queue into
bytecodealliance:main
with commit Jul 21, 2025
454d688
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #1331 by Alex
@TartanLlama would love to hear from you about these changes as well as you wrote the original test case.
There are still 26 codegen tests failing:
import_export_func.wit: confuses function foo and namespace foo 😢multiversion: we don't support versioned namespaces, yetvariants-unioning-types.wit: I guess this is import/export type incompatibility as these types are part of a world and not an interfaceresource-borrow-in-record.wit: we don't include<span>here