feat: implement missing async arg result handling - #1342
Merged
alexcrichton merged 1 commit intoJul 25, 2025
Merged
Conversation
vados-cosmonic
marked this pull request as draft
July 25, 2025 11:13
vados-cosmonic
force-pushed
the
feat=implement-missing-async-arg-result-handling
branch
from
July 25, 2025 11:23
8227b40 to
3badd19
Compare
This commit implements some (but not all) of the async argument and parameter handling that is emitted for function calls.
vados-cosmonic
force-pushed
the
feat=implement-missing-async-arg-result-handling
branch
from
July 25, 2025 11:34
3badd19 to
398d8ce
Compare
vados-cosmonic
marked this pull request as ready for review
July 25, 2025 11:34
Contributor
Author
|
The Test Async failure seems to be pre-existing (and "allowed to fail") so I'm figuring I can ignore it for now. I also don't think this PR would have been the one to fix that, given the error, but if so willing to dig in! Before (on `main`)This PR |
alexcrichton
approved these changes
Jul 25, 2025
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Thanks! And yeah I've been meaning to look at that failure but haven't had a chance to get around to it yet
Merged
via the queue into
bytecodealliance:main
with commit Jul 25, 2025
7ece07d
21 of 22 checks passed
vados-cosmonic
deleted the
feat=implement-missing-async-arg-result-handling
branch
July 28, 2025 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements some (but not all) of the async argument and parameter handling that is emitted for function calls.