fix(core): result check for async function - #1355
Merged
alexcrichton merged 2 commits intoAug 18, 2025
Merged
Conversation
This commit fixes a check that was incorrectly looking at the CM level function in the case of an async guest import when determining whether it had the right results. The problem with the existing logic is that it was trying to check for a constraint on the wrong function -- the guest import being lowered rather than the core function underneath that. The case that makes this obvious was something like an `run: async func()` where the CM level function clearly has no result, but the underlying core function being async lifted must of course have a i32 status code as a result.
vados-cosmonic
force-pushed
the
fix(core)=async-function-result-check
branch
from
August 16, 2025 06:07
19de614 to
b496f76
Compare
alexcrichton
approved these changes
Aug 18, 2025
alexcrichton
enabled auto-merge
August 18, 2025 17:31
Merged
via the queue into
bytecodealliance:main
with commit Aug 18, 2025
92cca96
38 of 44 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a check that was incorrectly looking at the CM level function in the case of an async guest import when determining whether it had the right results.
The problem with the existing logic is that it was trying to check for a constraint on the wrong function -- the guest import being lowered rather than the core function underneath that.
The case that makes this obvious was something like an
run: async func()where the CM level function clearly has no result, but the underlying core function being async lifted must of course have a i32 status code as a result.