Parse wit folder in generate! with inline - #1356
Merged
pchickey merged 2 commits intoAug 19, 2025
Merged
Conversation
This commit updates handling of the `inline` attribute in the `generate!` macro of the Rust bindings generator. Previously if `inline` was specified it would by default lookup nothing on the filesystem unless `path` was specified. This contradicts the documentation though that `./wit` is the default lookup path. To resolve this this commit adds a check to see if `./wit` exists, and if so parses it. This keeps the default search path behavior without requiring its existence when using `inline`.
pchickey
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates handling of the
inlineattribute in thegenerate!macro of the Rust bindings generator. Previously ifinlinewas specified it would by default lookup nothing on the filesystem unlesspathwas specified. This contradicts the documentation though that./witis the default lookup path. To resolve this this commit adds a check to see if./witexists, and if so parses it. This keeps the default search path behavior without requiring its existence when usinginline.