Prepare tests to run on WASIp3 - #1688
Merged
Merged
Conversation
This commit updates various bits/pieces of infrastructure/tests to ensure that all tests can run on WASIp3 targets in addition to WASIp2 targets. This isn't yet added to CI because toolchains aren't published quite just yet, but everything's been tested locally for now. The changes here are: * The wit-component/wasm-tools dependencies are updated. * Task state in Rust bindings is now stored in a TLS variable for wasip3 instead of a context slot like in wasip2. This is because context slots are taken in wasip3 for ABI details (stack pointer and TLS base). * Task state management in TLS on no-std builds requires an auxiliary C file to store the actual thread local. * Tests in C using context slots have a similar change where for wasip2 they use the context slot but for wasip3 they're now using a TLS variable. * Tests in Rust using TLS and relying on that being global are updated to use `static` variables instead as on wasip3 targets TLS is per-task, not global.
dicej
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates various bits/pieces of infrastructure/tests to ensure that all tests can run on WASIp3 targets in addition to WASIp2 targets. This isn't yet added to CI because toolchains aren't published quite just yet, but everything's been tested locally for now. The changes here are:
staticvariables instead as on wasip3 targets TLS is per-task, not global.