markdown: don't nest a link inside a link - #1689
Merged
alexcrichton merged 1 commit intoAug 19, 2026
Merged
Conversation
`print_ty` already writes a named type as a markdown link, and then the html pass in `finish` wrapped that same code span in a second link, so a type reference came out as `<a href="#r"><a href="#r"><code>r</code></a></a>`. Markdown links can't nest, so track whether we're inside one and leave the code span alone. The regression test goes in this crate's `tests/codegen.rs`, which wasn't being run: `test_unit` names crates individually and `--workspace --exclude 'wit-bindgen*'` filters this one out. Add it to that list.
alexcrichton
approved these changes
Aug 19, 2026
alexcrichton
enabled auto-merge
August 19, 2026 19:07
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
print_tywrites a named type as a markdown link, and then the html pass infinishwraps every code span matching a known anchor in another link. For a typereference that's the same span twice, so the html comes out as
which is what #1516 reported. Markdown links can't nest, so a bool tracking whether
we're inside one is enough to skip the second wrap. The
.mdoutput is unchanged;only the html differs.
The regression test goes in
crates/markdown/tests/codegen.rs, which turned out notto run anywhere —
test_unitnames crates individually and--workspace --exclude 'wit-bindgen*'filters this one out, so the test added in#1673 hasn't been running either. Added one line to
test_unitfor it.Closes #1516