Skip to content

sparse_mm should use sparse.mm by default for unbatched CSR matrices #71

Description

@theo-barfoot

Following the benchmark results which states:

  • For CSR backward, torch spmm outperforms tsgu spmm in both time and peak memory; tsgu spmm incurs extra memory due to internal CSR→COO conversion for gradient computation.
  • tsgu spmm supports CSR gradients contrary to current public PyTorch documentation statements.

And, the confirmation of the PyTorch documentation not accurately reflecting this, as raised in pytorch/pytorch#172550

The function sparse_mm should be updated to use the PyTorch function for unbatched CSR matrices.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions