Repository navigation
test(e2e): EXPERIMENT simulate lost iOS taps for #505 (do not merge) - #506
Closed
KisaneNeko wants to merge 5 commits into
Closed
KisaneNeko wants to merge 5 commits into
KisaneNeko wants to merge 5 commits into
Conversation
On CI the XCUITest tap on "Open React Native" is sometimes delivered but the NavigationLink doesn't push. The test then re-enabled Detox synchronization in a finally block, and that call never returned: DetoxSync keeps the app busy on "React Native (bundle load)" until RN content appears. The test hung until the 720s Jest timeout. Retry the tap (up to 3 attempts within the existing timeout, only while the button is still visible) and only re-enable synchronization once RN is visible. Refs callstack#498
Contributor
Author
|
Experiment done, results are in #505. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #505
Experiment, do not merge. I'll close it once CI has run.
Problem
#505's retry and fail-fast paths only run when the tap is lost, which is rare, so a normal CI run doesn't exercise them.
Change
appleAppDetoxUtils.cjs: whenE2E_SIMULATE_LOST_TAPis set, skip the tap (first: only on attempt 1,all: on every attempt).appleapp-road-test/action.yml: Expo 57 runs withall, Vanilla and Expo 58 withfirst.Expected: Vanilla and Expo 58 log
re-tappingand pass. Expo 57 fails each test after ~60 s instead of hanging for 12 min.