Repository navigation
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
roboomp
left a comment
There was a problem hiding this comment.
P2 — this is a cost-bearing default behavior change; automatic enablement needs explicit maintainer sign-off.
Blocking: caller-silent agent requests now enable 1.25× cache writes. Should-fix: the exported Responses output type narrows valid callers, the gateway rejection misses nested output markers, and affected package changelogs are absent.
Focused verification passed: 231 tests across the four touched suites.
Thanks @ZenAlexa for the structured capability path and targeted coverage.
296d139 to
e667f42
Compare
e667f42 to
eed2185
Compare
|
I addressed the type, gateway, and changelog findings in |
Merge current main and preserve stateful request prefixes.
|
Kept explicit prompt caching opt-in and fixed the cache markers so later tool calls can reuse the existing Responses prefix. |
Keep the stateful test imports and align gateway requests with the current authentication fixture. Signed-off-by: ZenAlexa <zimingwang945@gmail.com>
Retain explicit-cache boundary handling alongside current auth-broker usage flushing and terminal progress updates. Signed-off-by: ZenAlexa <zimingwang945@gmail.com>
Retain opt-in cache boundaries with current account refresh, resumed session affinity, catalog discovery, and interrupted tool-result handling. Signed-off-by: ZenAlexa <zimingwang945@gmail.com>
what
kept explicit prompt caching opt-in and fixed cache boundaries across tool loops. omitted policy and caller-supplied markers keep their existing behavior.
chat completions selects stable assistant and tool boundaries. responses keeps function-output markers aligned with the stored prefix across incremental requests and falls back to the existing full replay when history changes. the content union stays intact, the gateway rejects unsupported nested markers, and custom endpoint configuration accepts
supportsPromptCacheBreakpoints.why
related to #12780. explicit caching needs a stable prefix across tool calls and later dialogue. automatic cache enablement remains a separate policy decision.
current main
merged
main@b91db66e9into7fcaeb3ce7. the cache policy remains opt-in, and both changelog entries stay under unreleased.testing
on
7fcaeb3ce7, 455 tests passed across 19 files with bun 1.4.2 on macos arm64. these cover cache boundaries, incremental replay, gateway marker rejection, model configuration, session cleanup, provider pricing, and the stats and model-browser consumers.BUN_INSTALL_AUTO=disable bun --no-install test --timeout 60000 \ packages/coding-agent/test/model-browser.test.ts \ packages/coding-agent/test/model-registry.test.ts \ packages/catalog/test/time-based-pricing.test.ts \ packages/catalog/test/nanogpt-model-limits.test.ts \ packages/catalog/test/cursor-pricing.test.ts \ packages/catalog/test/devin-discovery.test.ts \ packages/catalog/test/cursor-discovery.test.ts \ packages/catalog/test/kilo-discovery.test.ts \ packages/catalog/test/gemini-argon-pricing.test.ts \ packages/agent/test/agent.test.ts \ packages/ai/test/openai-configuration-update.test.ts \ packages/ai/test/auth-gateway-openai-prompt-cache.test.ts \ packages/ai/test/openai-responses-cache-affinity.test.ts \ packages/ai/test/google-gemini-cli-variant-routing.test.ts \ packages/ai/test/provider-session-release.test.ts \ packages/ai/test/openai-responses-delta-input.test.ts \ packages/ai/test/openai-responses-stateful.test.ts \ packages/ai/test/openai-completions-cache-affinity.test.ts \ packages/stats/test/db-cost.test.tsbun checkpassed, including lint, formatting, workspace typechecks and rust checks. a separate request-lifecycle scenario passed 19 checks for opt-in transitions, cache key changes, incremental replay and gateway rejection.optional transformers inference, live billing and cache-hit rates remain outside this run. the rust check used the project's stub for apple foundation models because the optional sdk was unavailable.
bun checkpasses