refactor(api): additional findings resolvers - #7534
Open
lcampbell2 wants to merge 9 commits into
Open
lcampbell2 wants to merge 9 commits into
lcampbell2 wants to merge 9 commits into
Conversation
lcampbell2
commented
Aug 20, 2026
lcampbell2
commented
Collaborator
- refactors additionalFindings object to match fields established in feat(scanners): additional findings processor #7518
- refactors Domain.additionalFindings loader to a Relay connection and adds pagination, sorting, and filtering support
- removes legacy top-25 additional findings query code
FestiveKyle
reviewed
Aug 28, 2026
lcampbell2
removed this pull request from stack #7541
September 18, 2026 16:51
lcampbell2
added this pull request to stack #7589
September 18, 2026 16:51
lcampbell2
removed this pull request from stack #7589
September 18, 2026 16:53
lcampbell2
changed the title
FestiveKyle
reviewed
Sep 21, 2026
FestiveKyle
left a comment
FestiveKyle
left a comment
Collaborator
There was a problem hiding this comment.
Domain CSV exports break for me after the new additionalFindings documents start populating. I think due to the webComponents section
| sortTemplate = aql`SORT TO_NUMBER(finding._key) ${relayDirectionString}` | ||
| } else { | ||
| sortTemplate = aql` | ||
| SORT finding.${orderBy.field} ${orderBy.direction}, TO_NUMBER(finding._key) ${relayDirectionString} |
Collaborator
There was a problem hiding this comment.
Severity and Confidence are sorted alphabetically, should probably be sorted by rank instead (high -> med -> low)
| sortTemplate = aql`SORT TO_NUMBER(finding._key) ${relayDirectionString}` | ||
| } else { | ||
| sortTemplate = aql` | ||
| SORT finding.${orderBy.field} ${orderBy.direction}, TO_NUMBER(finding._key) ${relayDirectionString} |
Collaborator
There was a problem hiding this comment.
Sorting by Severity ASC break pagination, returns an empty list. I think it has to do with undefined values in the cursor as severity is optional. Not 100% sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.