Mithril: Follow GitHub redirects when fetching release data and networks.json - #1910
Merged
rdlrt merged 2 commits intoJul 17, 2026
Conversation
Add -L to the curl resolving the latest release in guild-deploy.sh, future proofing against upcoming URL updates served through redirects.
Add -L to the curl fetching networks.json in mithril.library, future proofing against upcoming URL updates served through redirects.
Contributor
Author
|
Hi @TrevorBenson, could I ask for a quick review of this small PR? |
Scitz0
approved these changes
Jul 17, 2026
Scitz0
pushed a commit
that referenced
this pull request
Jul 23, 2026
Follow-up to #1910 (which added redirect-following): now that the Mithril repository has moved, this repoints every Mithril GitHub URL from `input-output-hk/mithril` to `IntersectMBO/mithril`: - `guild-deploy.sh`: the release resolution (`api.github.com`) and the tarball download. - `mithril.library`: the `networks.json`, verification-key, and era fetches. - `.github/workflows/mithril-latest.yml`: the release-tracking version-bump lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a hardening of the Mithril GitHub fetches to make them future proof with upcoming updates of the URLs, which may be served through redirects:
-Lto the curl call resolving the latest Mithril release inguild-deploy.sh(download_mithril)-Lto the curl call fetchingnetworks.jsoninmithril.library(set_node_minimum_version)