read.rs

use crate::util::{RequestHelper, TestApp};
use crates_io::models::{NewUser, User};
use crates_io::views::EncodablePublicUser;
use crates_io_test_utils::builders::{OauthGithubBuilder, UserBuilder};
use insta::assert_snapshot;
use serde::Deserialize;

#[derive(Deserialize)]
pub struct UserShowPublicResponse {
    pub user: EncodablePublicUser,
}

#[tokio::test(flavor = "multi_thread")]
async fn show() {
    let (app, anon, _) = TestApp::init().with_user().await;
    app.db_new_user("Bar").await;

    let json: UserShowPublicResponse = anon.get("/api/v1/users/foo").await.good();
    assert_eq!(json.user.login, "foo");

    // Lookup by username is case insensitive; returned data uses capitalization in database
    let json: UserShowPublicResponse = anon.get("/api/v1/users/bAr").await.good();
    assert_eq!(json.user.login, "Bar");
    assert_eq!(json.user.url, "https://github.com/Bar");

    // Username not in database results in 404
    let response = anon.get::<()>("/api/v1/users/not_a_user").await;
    assert_snapshot!(response.status(), @"404 Not Found");
}

#[tokio::test(flavor = "multi_thread")]
async fn show_latest_user_case_insensitively() {
    let (app, anon) = TestApp::init().empty().await;
    let conn = app.db_conn().await;

    // Please do not delete or modify the setup of this test in order to get it to pass.
    // This setup mimics how GitHub works. If someone abandons a GitHub account, the username is
    // available for anyone to take. We need to support having multiple user accounts
    // with the same gh_login in crates.io. `gh_id` is stable across renames, so that field
    // should be used for uniquely identifying GitHub accounts whenever possible. For the
    // crates.io/user/{username} pages, the best we can do is show the last crates.io account
    // created with that username.

    let user1 = UserBuilder::new()
        .with_username("foobar")
        .with_display_name("I was first then deleted my github account")
        .new_user();
    let user1_id = user1.insert(&conn).await.unwrap();
    let user1 = User::find(&conn, user1_id).await.unwrap();
    OauthGithubBuilder::for_user(&user1).insert(&conn).await;

    let user2 = UserBuilder::new()
        .with_username("FOOBAR")
        .with_display_name("I was second, I took the foobar username on github")
        .new_user();
    let user2_id = user2.insert(&conn).await.unwrap();
    let user2 = User::find(&conn, user2_id).await.unwrap();
    OauthGithubBuilder::for_user(&user2).insert(&conn).await;

    let json: UserShowPublicResponse = anon.get("/api/v1/users/fOObAr").await.good();
    assert_eq!(
        "I was second, I took the foobar username on github",
        json.user.name.unwrap()
    );
}

#[tokio::test(flavor = "multi_thread")]
async fn user_without_github_account() {
    let (app, anon) = TestApp::init().empty().await;
    let conn = app.db_conn().await;

    let new_user = NewUser::builder()
        // The gh_id column will eventually be removed; there are currently records in production
        // that have `-1` for their `gh_id` because the associated GitHub accounts have been deleted
        .gh_id(-1)
        .gh_login("foobar")
        .username("foobar")
        .name("I deleted my github account")
        .gh_encrypted_token(&[])
        .build();
    new_user.insert(&conn).await.unwrap();
    // This user doesn't have a linked record in `oauth_github`

    // The crates.io username still exists
    let json: UserShowPublicResponse = anon.get("/api/v1/users/fOObAr").await.good();
    assert_eq!("I deleted my github account", json.user.name.unwrap());
}