Episode 01 style - #76
Merged
archaeolauren merged 5 commits intoJun 11, 2026
Merged
Conversation
|
NOTE: This Pull Request (#76) was previously merged |
sstevens2
approved these changes
Jun 9, 2026
sstevens2
left a comment
sstevens2
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @archaeolauren! These changes generally improve the text structure and make it more readable. I left a couple of small comments but am otherwise happy to merge.
I did note a bigger issue with the British vs American spellings. We might need to file an issue for the maintainers to discuss on that topic.
|
|
||
| - there is no README documentation to orient the user | ||
| - there is no licence information to say how the code can be reused (which then means it cannot be reused at all) | ||
| - there is no license information to say how the code can be reused (which then means it cannot be reused at all) |
Collaborator
There was a problem hiding this comment.
this is a difference in British vs American spelling. The python lesson was written in the UK. The lesson maintainers of this workshop may want to decide if plan to change or keep these spellings generally.
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 11, 2026
Auto-generated via `{sandpaper}`
Source : a77bbc0
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-06-11 14:34:05 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 0f08b6b
Branch : main
Author : Lauren P <laurenvicpratt@gmail.com>
Time : 2026-06-11 14:32:00 +0000
Message : Merge pull request #76 from archaeolauren/lesson_01_style
Episode 01 style
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
Auto-generated via `{sandpaper}`
Source : 619c556
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-06-16 03:25:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 0f08b6b
Branch : main
Author : Lauren P <laurenvicpratt@gmail.com>
Time : 2026-06-11 14:32:00 +0000
Message : Merge pull request #76 from archaeolauren/lesson_01_style
Episode 01 style
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 23, 2026
Auto-generated via `{sandpaper}`
Source : 4ffc0f7
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-06-23 02:37:01 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 0f08b6b
Branch : main
Author : Lauren P <laurenvicpratt@gmail.com>
Time : 2026-06-11 14:32:00 +0000
Message : Merge pull request #76 from archaeolauren/lesson_01_style
Episode 01 style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style and clarity updates to lesson 1. Reduces wordiness, removes colloquialisms, fixes grammatical errors, etc. I also addressed some language that read to me as judgemental -- I think it's important to avoid shaming learners who might previously have used some of the approaches we're critiquing. Added a screenshot of the inherited code file
my code v2.R; if I did it right, I think it should resolve #34.