Skip to content

Hardcoded path demo - #77

Closed
archaeolauren wants to merge 6 commits into
carpentries-incubator:mainfrom
archaeolauren:hardcoded-path-demo
Closed

Hardcoded path demo#77
archaeolauren wants to merge 6 commits into
carpentries-incubator:mainfrom
archaeolauren:hardcoded-path-demo

Conversation

@archaeolauren

Copy link
Copy Markdown
Collaborator

Currently, the lesson demonstrates that the inherited code my code v2.R will not run because the paths are hard-coded both at the end of episode 1 and again at the start of episode 2. This seems unnecessary. My suggested fix (implemented here) is to remove the less detailed demo from episode 1. I also gave the section in episode 2 a new header, and removed some duplicated language.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/better-research-software-r/compare/md-outputs..md-outputs-PR-77

The following changes were observed in the rendered markdown documents:

 01-introduction.md                 | 122 ++++++++++++++++---------------------
 02-better-start-version-control.md |  13 ++--
 md5sum.txt                         |   5 +-
 3 files changed, 59 insertions(+), 81 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-05-01 15:52:44 +0000

@sstevens2

Copy link
Copy Markdown
Collaborator

This PR accidently contains commit from other PR. @archaeolauren will fix and resubmit

@sstevens2 sstevens2 closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants