-
Notifications
You must be signed in to change notification settings - Fork 6
Refactor export stage to use a config dict representing the workbook structure #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ca5b6f5
working file
Damonamajor 788004b
Merge branch 'master' into desk-review-workbook-paramaterization
Damonamajor 671d03c
update helper
Damonamajor e1c8cd2
lintr changes
Damonamajor 25fca04
lintr
Damonamajor 593b4cd
Jean edtis
Damonamajor a8ea312
update to select based on schema
Damonamajor 28c465a
Merge branch 'master' into desk-review-workbook-paramaterization
Damonamajor 7f87bda
explicetely remove mv columns
Damonamajor 2793a7f
lintr
Damonamajor 7c06466
standardize to same as model
Damonamajor 1304679
revert to set diff
Damonamajor 3e4d1e0
add nolint
Damonamajor 9a1e9bf
Update pipeline/07-export.R
Damonamajor 91d01dd
add commenting for desk review and iasworld upload
Damonamajor 7392423
lintr
Damonamajor 98f33d4
Merge branch 'master' into desk-review-workbook-paramaterization
Damonamajor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only pulled the shared helpers into this file (API and workbook) in model_res_avm. This means 2 out of the 4 small functions. But, then I noticed when doing this version that we may not even want to put them in the helper since nothing is shared (since we don't have the API workbook). Do you have any preference in how we want these 4 small functions stored between both repositories?
Just let me know if you want changes to this or the other one.
ccao-data/model-res-avm#538 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion, optional] I don't have strong feelings! I think it makes sense in the res model to define the functions that are specific to one script in the body of that script, and factor out shared functions in
helpers.R; for the condo model, I think it makes sense to just match the organization that the res model uses, even though functions are not shared in the same way -- I find it useful for the organization of the two projects to be as close as possible, for the sake of making it easier to find things. So I would just copy the way the res model organizes these functions, even though the logic of the organization is less apparent in this context.