Persist logged columns when we train in log space - #178
Merged
Merged
Conversation
wagnerlmichael
marked this pull request as ready for review
August 31, 2026 21:24
wagnerlmichael
requested review from
jeancochrane and
wrridgeway
as code owners
August 31, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of ccao-data/model-res-avm#555 (comment).
This PR preserves logged price and prediction data for easier debuggging/troubleshooting/eda when we run the model with log transform active.
Summary of data changes:
meta_sale_price_log,pred_card_initial_fmv_logmeta_sale_price_log,pred_card_initial_fmv_logpred_card_initial_fmv_logIn the case of a non-logged model, these new columns values will be NA.
Closes #177