Skip to content

fix(web): prevent dark theme navigation flash - #219

Merged
ccarvalho-eng merged 1 commit into
mainfrom
ccarvalho/fix-dark-theme-flash
Sep 5, 2026
Merged

fix(web): prevent dark theme navigation flash#219
ccarvalho-eng merged 1 commit into
mainfrom
ccarvalho/fix-dark-theme-flash

Conversation

@ccarvalho-eng

Copy link
Copy Markdown
Owner

Motivation

Dark mode could briefly render the light theme while moving between dashboard pages. Navigation triggered full document loads, and the persisted theme was not applied until after the stylesheet loaded.

Test Plan

  • Added a regression test that verifies the saved theme is applied before stylesheet loading.
  • Verified dashboard navigation uses LiveView navigation.
  • Verified the source and compiled JavaScript assets remain synchronized.
  • Passed the complete test suite, static analysis, dependency audit, documentation build, production compilation, and package dry run.

Next Steps

None.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: b24d6199-d9bf-438a-b437-b589fe91f382

📥 Commits

Reviewing files that changed from the base of the PR and between 35f76fa and e31826c.

📒 Files selected for processing (5)
  • assets/js/app.js
  • lib/aludel/web/components/layouts.ex
  • lib/aludel/web/components/layouts/root.html.heex
  • priv/static/app.js
  • test/aludel_web/live/dashboard_live_test.exs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ccarvalho-eng
ccarvalho-eng merged commit 98a07a8 into main Sep 5, 2026
11 checks passed
@ccarvalho-eng
ccarvalho-eng deleted the ccarvalho/fix-dark-theme-flash branch September 5, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant