Skip to content

Fix issue #305: Merge dotted keys when non-dotted key with same prefix follows - #306

Merged
cdgriffith merged 2 commits into
cdgriffith:developfrom
jbemmel:test-305
Nov 4, 2026
Merged

cdgriffith merged 2 commits into
cdgriffith:developfrom
jbemmel:test-305

Conversation

@jbemmel

@jbemmel jbemmel commented Feb 24, 2026

Copy link
Copy Markdown
Contributor
  • Add test case for issue Dotted keys read from YAML are lost with box_dots / default_box #305 documenting the bug
  • Fix __convert_and_store to merge dict values into existing Box when:
    • box_dots is enabled
    • key already exists as a Box (created from dotted keys)
    • during initialization (__created is False)
  • This ensures dotted keys like 'a.b: c' are preserved when followed by a non-dotted key like 'a: {d: e}' in YAML files

cdgriffith and others added 2 commits February 21, 2026 10:19
…same prefix follows

- Add test case for issue cdgriffith#305 documenting the bug
- Fix __convert_and_store to merge dict values into existing Box when:
  - box_dots is enabled
  - key already exists as a Box (created from dotted keys)
  - during initialization (__created is False)
- This ensures dotted keys like 'a.b: c' are preserved when followed by
  a non-dotted key like 'a: {d: e}' in YAML files
@cdgriffith
cdgriffith changed the base branch from master to develop November 4, 2026 00:40
@cdgriffith
cdgriffith merged commit 2654ecb into cdgriffith:develop Nov 4, 2026
34 checks passed
@cdgriffith cdgriffith mentioned this pull request Nov 4, 2026
@jbemmel
jbemmel deleted the test-305 branch November 4, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants