Skip to content

fix: remove glide account ID - #459

Merged
gcharest merged 1 commit into
mainfrom
fix/remove_glide_account
Aug 29, 2025
Merged

fix: remove glide account ID#459
gcharest merged 1 commit into
mainfrom
fix/remove_glide_account

Conversation

@gcharest

Copy link
Copy Markdown
Contributor

Summary | Résumé

Removed Glide Account ID

@gcharest
gcharest requested a review from a team August 29, 2025 19:38
@github-actions

Copy link
Copy Markdown

Central account

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 3 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_iam_policy.log_archive_read
aws_kms_key.log_archive_encrypt
aws_s3_bucket_policy.log_archive_bucket
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place
 <= read (data resources)

Terraform will perform the following actions:

  # data.aws_iam_policy_document.log_archive_read will be read during apply
  # (config refers to values not yet known)
 <= data "aws_iam_policy_document" "log_archive_read"  {
      ~ id            = "3221625606" -> (known after apply)
      ~ json          = jsonencode(
            {
              - Statement = [
                  - {
                      - Action   = [
                          - "s3:ListBucket",
                          - "s3:GetObject",
                        ]
                      - Effect   = "Allow"
                      - Resource = [
                          - "arn:aws:s3:::cbs-log-archive-871282759583/*",
                          - "arn:aws:s3:::cbs-log-archive-871282759583",
                        ]
                    },
                  - {
                      - Action   = "kms:Decrypt"
                      - Effect   = "Allow"
                      - Resource = "arn:aws:kms:ca-central-1:871282759583:key/c4591f87-9445-4840-acb6-a5569e703c93"
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> (known after apply)
      ~ minified_json = jsonencode(
            {
              - Statement = [
                  - {
                      - Action   = [
                          - "s3:ListBucket",
                          - "s3:GetObject",
                        ]
                      - Effect   = "Allow"
                      - Resource = [
                          - "arn:aws:s3:::cbs-log-archive-871282759583/*",
                          - "arn:aws:s3:::cbs-log-archive-871282759583",
                        ]
                    },
                  - {
                      - Action   = "kms:Decrypt"
                      - Effect   = "Allow"
                      - Resource = "arn:aws:kms:ca-central-1:871282759583:key/c4591f87-9445-4840-acb6-a5569e703c93"
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> (known after apply)
      - version       = "2012-10-17" -> null

      ~ statement {
          - not_actions   = [] -> null
          - not_resources = [] -> null
            # (3 unchanged attributes hidden)
        }
      ~ statement {
          - not_actions   = [] -> null
          - not_resources = [] -> null
            # (3 unchanged attributes hidden)
        }
    }

  # aws_iam_policy.log_archive_read will be updated in-place
  ~ resource "aws_iam_policy" "log_archive_read" {
        id               = "arn:aws:iam::871282759583:policy/CbsASEAReaderRole"
        name             = "CbsASEAReaderRole"
      ~ policy           = jsonencode(
            {
              - Statement = [
                  - {
                      - Action   = [
                          - "s3:ListBucket",
                          - "s3:GetObject",
                        ]
                      - Effect   = "Allow"
                      - Resource = [
                          - "arn:aws:s3:::cbs-log-archive-871282759583/*",
                          - "arn:aws:s3:::cbs-log-archive-871282759583",
                        ]
                      - Sid      = ""
                    },
                  - {
                      - Action   = "kms:Decrypt"
                      - Effect   = "Allow"
                      - Resource = "arn:aws:kms:ca-central-1:871282759583:key/c4591f87-9445-4840-acb6-a5569e703c93"
                      - Sid      = ""
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> (known after apply)
        tags             = {}
        # (5 unchanged attributes hidden)
    }

  # aws_kms_key.log_archive_encrypt will be updated in-place
  ~ resource "aws_kms_key" "log_archive_encrypt" {
        id                                 = "c4591f87-9445-4840-acb6-a5569e703c93"
      ~ policy                             = (sensitive)
        tags                               = {}
        # (13 unchanged attributes hidden)
    }

  # aws_s3_bucket_policy.log_archive_bucket will be updated in-place
  ~ resource "aws_s3_bucket_policy" "log_archive_bucket" {
        id     = "cbs-log-archive-871282759583"
      ~ policy = jsonencode(
          ~ {
              ~ Statement = [
                  ~ {
                      ~ Principal = {
                          ~ AWS = [
                                # (7 unchanged elements hidden)
                                "arn:aws:iam::767397971970:role/CbsSatelliteReplicateToLogArchive",
                              - "arn:aws:iam::767397913019:role/CbsSatelliteReplicateToLogArchive",
                                "arn:aws:iam::739275439843:role/CbsSatelliteReplicateToLogArchive",
                                # (25 unchanged elements hidden)
                            ]
                        }
                        # (3 unchanged elements hidden)
                    },
                  ~ {
                      ~ Principal = {
                          ~ AWS = [
                                # (7 unchanged elements hidden)
                                "arn:aws:iam::767397971970:role/CbsSatelliteReplicateToLogArchive",
                              - "arn:aws:iam::767397913019:role/CbsSatelliteReplicateToLogArchive",
                                "arn:aws:iam::739275439843:role/CbsSatelliteReplicateToLogArchive",
                                # (25 unchanged elements hidden)
                            ]
                        }
                        # (3 unchanged elements hidden)
                    },
                    {
                        Action    = "s3:GetObject"
                        Effect    = "Allow"
                        Principal = {
                            AWS = "arn:aws:iam::346725238039:role/CBS-ReaderRole-prod-ca-central-1"
                        }
                        Resource  = [
                            "arn:aws:s3:::cbs-log-archive-871282759583/*",
                            "arn:aws:s3:::cbs-log-archive-871282759583",
                        ]
                    },
                ]
                # (1 unchanged element hidden)
            }
        )
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.log_archive_access_bucket.aws_s3_bucket.this,
  on .terraform/modules/log_archive_access_bucket/S3_log_bucket/main.tf line 8, in resource "aws_s3_bucket" "this":
   8: resource "aws_s3_bucket" "this" {

server_side_encryption_configuration is deprecated. Use the
aws_s3_bucket_server_side_encryption_configuration resource instead.

(and 6 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Releasing state lock. This may take a few moments...
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_event_rule.cbs"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.event_bus_invoke_remote_event_bus"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.log_archive_read"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.event_bus_invoke_remote_event_bus"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.log_archive_read"]
WARN - plan.json - main - Missing Common Tags: ["aws_kms_key.log_archive_encrypt"]
WARN - plan.json - main - Missing Common Tags: ["aws_sns_topic.log_archive"]

26 tests, 19 passed, 7 warnings, 0 failures, 0 exceptions

@gcharest
gcharest enabled auto-merge (squash) August 29, 2025 19:42
@gcharest
gcharest merged commit b0710c1 into main Aug 29, 2025
36 checks passed
@gcharest
gcharest deleted the fix/remove_glide_account branch August 29, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants