fix: update alt text for government logos in email templates (#422)

* fix: update alt text for government logos in email templates

* chore: bump version

* chore: bump version one higher so incident fix can go out first

Author: andrewleith

.github/actions/waffles/requirements.txt

@@ -2,4 +2,4 @@ docopt==0.6.2
 Flask==2.3.3
 markupsafe==2.1.5
 setuptools==78.1.1 # required for distutils in Python 3.12
-git+https://github.com/cds-snc/notifier-utils.git@53.2.30#egg=notifications-utils
+git+https://github.com/cds-snc/notifier-utils.git@53.2.31#egg=notifications-utils

notifications_utils/jinja_templates/email/_fip_banner.jinja2

@@ -9,7 +9,7 @@
                 {% if fip_banner_english %}
                 <img
                 src="https://assets.notification.canada.ca/gc-logo-en.png?20210531"
-                alt="Government of Canada / Gouvernement du Canada"
+                alt="Government of Canada"
                 height="55"
                 width="286"
                 border="0"
@@ -19,7 +19,7 @@
                 {% if fip_banner_french or brand_name == "canada.ca-fr" %}
                 <img
                 src="https://assets.notification.canada.ca/gc-logo-fr.png?20210531"
-                alt="Gouvernement du Canada / Government of Canada"
+                alt="Gouvernement du Canada"
                 height="55"
                 width="286"
                 border="0"

notifications_utils/jinja_templates/email/email_preview_template.jinja2

@@ -41,7 +41,7 @@
         <div style="margin: 20px auto 30px auto;">
           <img
             src="https://{{ asset_domain }}/gc-logo-en.png"
-            alt="Government of Canada / Gouvernement du Canada"
+            alt="Government of Canada"
             height="55"
             width="281"
           />
@@ -52,7 +52,7 @@
         <div style="margin: 20px auto 30px auto;">
           <img
             src="https://{{ asset_domain }}/gc-logo-fr.png"
-            alt="Gouvernement du Canada / Government of Canada"
+            alt="Gouvernement du Canada"
             height="55"
             width="281"
           />

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "notifications-utils"
-version = "53.2.30"
+version = "53.2.31"
 description = "Shared python code for Notification - Provides logging utils etc."
 authors = ["Canadian Digital Service"]
 license = "MIT license"

tests/test_template_types.py

@@ -50,8 +50,10 @@ def test_fip_banner_english(renderer, show_banner):
     email = renderer({"content": "hello world", "subject": ""})
     email.fip_banner_english = show_banner
     if show_banner:
-        assert "gc-logo-en.png" in str(email)
-        assert "canada-logo.png" in str(email)
+        rendered_email = str(email)
+        assert "gc-logo-en.png" in rendered_email
+        assert "canada-logo.png" in rendered_email
+        assert 'alt="Government of Canada"' in rendered_email
     else:
         assert "gc-logo-en.png" not in str(email)
         assert "canada-logo.png" not in str(email)
@@ -81,8 +83,10 @@ def test_fip_banner_french(renderer, show_banner):
     email.fip_banner_english = False
     email.fip_banner_french = show_banner
     if show_banner:
-        assert "gc-logo-fr.png" in str(email)
-        assert "canada-logo.png" in str(email)
+        rendered_email = str(email)
+        assert "gc-logo-fr.png" in rendered_email
+        assert "canada-logo.png" in rendered_email
+        assert 'alt="Gouvernement du Canada"' in rendered_email
     else:
         assert "gc-logo-fr.png" not in str(email)
         assert "canada-logo.png" not in str(email)