Exclude content length errors from recipient_error prop (#290)

* Exclude content length errors from recipient_error prop

* Formatting

Author: whabanks

.github/actions/waffles/requirements.txt

@@ -1,4 +1,4 @@
 docopt==0.6.2
 Flask==2.3.3
 markupsafe==2.1.4
-git+https://github.com/cds-snc/notifier-utils.git@52.1.9#egg=notifications-utils
+git+https://github.com/cds-snc/notifier-utils.git@52.1.10#egg=notifications-utils

notifications_utils/columns.py

@@ -59,6 +59,9 @@ def __init__(
             else ["phone number", "numéro de téléphone", "to"]
         )
 
+        # This won't mark a row as too long in all cases. A message can be too long if
+        # placeholder content is added by a user that exceeds the limit when added to
+        # the template's content.
         if template:
             template.values = row_dict
             self.message_too_long = template.is_message_too_long()
@@ -144,4 +147,9 @@ def __eq__(self, other):
 
     @property
     def recipient_error(self):
+        # TODO: This is a bandaid solution. We need to establish why we are calling this Cell property on
+        #       Cells that do not represent a recipient value.
+        if self.error is not None and "Some messages may be too long due to custom content." in self.error:
+            return False
+
         return self.error not in {None, self.missing_field_error}

pyproject.toml

@@ -5,7 +5,7 @@ include = '(notifications_utils|tests)/.*\.pyi?$'
 
 [tool.poetry]
 name = "notifications-utils"
-version = "52.1.9"
+version = "52.1.10"
 description = "Shared python code for Notification - Provides logging utils etc."
 authors = ["Canadian Digital Service"]
 license = "MIT license"