Debug annual limits (#364)

* Add debug logging

* fix logging

* Remove excessive logging, added specific logging for staging test

Author: whabanks

.github/actions/waffles/requirements.txt

@@ -2,4 +2,4 @@ docopt==0.6.2
 Flask==2.3.3
 markupsafe==2.1.5
 setuptools==75.6.0 # required for distutils in Python 3.12
-git+https://github.com/cds-snc/notifier-utils.git@53.2.1#egg=notifications-utils
+git+https://github.com/cds-snc/notifier-utils.git@53.2.2#egg=notifications-utils

notifications_utils/clients/redis/annual_limit.py

@@ -244,7 +244,12 @@ def seed_annual_limit_notifications(self, service_id: str, mapping: dict):
             current_app.logger.warning(f"Missing V2 fields when seeding annual limit for service {service_id}: {missing_fields}")
 
         # Store V2 fields
-        v2_result = self._redis_client.bulk_set_hash_fields(key=annual_limit_notifications_v2_key(service_id), mapping=v2_mapping)
+        current_app.logger.info(
+            f"[alimit-debug-redis] Setting notification_v2 values for service_id: {service_id} with mapping: {v2_mapping}"
+        )
+        self._redis_client.bulk_set_hash_fields(key=annual_limit_notifications_v2_key(service_id), mapping=v2_mapping)
+        v2_values = prepare_byte_dict(self._redis_client.get_all_from_hash(annual_limit_notifications_v2_key(service_id)), str)
+        current_app.logger.info(f"[alimit-debug-redis] Finished setting values, result is: {v2_values}")
 
         # Create a legacy mapping from either original legacy keys or mapped from V2 keys
         legacy_mapping = {}
@@ -268,9 +273,11 @@ def seed_annual_limit_notifications(self, service_id: str, mapping: dict):
         if legacy_mapping:
             self._redis_client.bulk_set_hash_fields(key=annual_limit_notifications_key(service_id), mapping=legacy_mapping)
 
-        # Only after successful storage, set the seeded flag
-        if v2_result:
-            self.set_seeded_at(service_id)
+        current_app.logger.info(f"[alimit-debug-redis] Setting seeded_at for service {service_id}")
+        self.set_seeded_at(service_id)
+        current_app.logger.info(
+            f"[alimit-debug-redis] Finished setting seeded_at, new value is: {self.get_seeded_at(service_id)}"
+        )
 
     def was_seeded_today(self, service_id):
         last_seeded_time = self.get_seeded_at(service_id)

notifications_utils/clients/redis/redis_client.py

@@ -125,9 +125,16 @@ def bulk_set_hash_fields(self, mapping, pattern=None, key=None, raise_exception=
         if self.active:
             try:
                 if pattern:
+                    current_app.logger.info(
+                        f"[alimit-debug-redis] bulk_set_hash_fields - Pattern branch. pattern: {pattern}, key: {key}, mapping: {mapping}"
+                    )
                     for key in self.redis_store.scan_iter(pattern):
                         self.redis_store.hmset(key, mapping)
+                    return True
                 if key:
+                    current_app.logger.info(
+                        f"[alimit-debug-redis] bulk_set_hash_fields - key branch. pattern: {pattern}, key: {key}, mapping: {mapping}"
+                    )
                     return self.redis_store.hmset(key, mapping)
             except Exception as e:
                 self.__handle_exception(e, raise_exception, "bulk_set_hash_fields", pattern)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "notifications-utils"
-version = "53.2.1"
+version = "53.2.2"
 description = "Shared python code for Notification - Provides logging utils etc."
 authors = ["Canadian Digital Service"]
 license = "MIT license"