Skip to content

Commit b9ab44e

Browse files
committed
feat: update recipient validation tests to utilize international billing rates
1 parent 4406906 commit b9ab44e

1 file changed

Lines changed: 12 additions & 31 deletions

File tree

tests/test_recipient_validation.py

Lines changed: 12 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from functools import partial
22

33
import pytest
4+
from notifications_utils.international_billing_rates import INTERNATIONAL_BILLING_RATES
45
from notifications_utils.recipients import (
56
InvalidAddressError,
67
InvalidEmailError,
@@ -138,55 +139,35 @@ def test_detect_local_phone_numbers(phone_number):
138139
assert is_local_phone_number(phone_number) is True
139140

140141

142+
def _billable_units(prefix):
143+
return INTERNATIONAL_BILLING_RATES[prefix]["billable_units"]
144+
145+
141146
@pytest.mark.parametrize(
142147
"phone_number, expected_info",
143148
[
144149
(
145-
"+447900900123",
150+
"+27-82-123-1234",
146151
international_phone_info(
147152
international=True,
148-
country_prefix="44", # UK
149-
billable_units=1,
153+
country_prefix="27", # South Africa
154+
billable_units=_billable_units("27"),
150155
),
151156
),
152157
(
153-
"+20-12-1234-1234",
154-
international_phone_info(
155-
international=True,
156-
country_prefix="20", # Egypt
157-
billable_units=3,
158-
),
159-
),
160-
(
161-
"+201212341234",
162-
international_phone_info(
163-
international=True,
164-
country_prefix="20", # Egypt
165-
billable_units=3,
166-
),
167-
),
168-
(
169-
"+79587714230",
158+
"+2302086859",
170159
international_phone_info(
171160
international=True,
172-
country_prefix="7", # Russia
173-
billable_units=1,
161+
country_prefix="230", # Mauritius
162+
billable_units=_billable_units("230"),
174163
),
175164
),
176165
(
177166
"1-202-555-0104",
178167
international_phone_info(
179168
international=False,
180169
country_prefix="1", # USA
181-
billable_units=1,
182-
),
183-
),
184-
(
185-
"+2302086859",
186-
international_phone_info(
187-
international=True,
188-
country_prefix="230", # Mauritius
189-
billable_units=2,
170+
billable_units=_billable_units("1"),
190171
),
191172
),
192173
],

0 commit comments

Comments
 (0)