|
| 1 | +"""Tests for provider-safe MCP tool names. |
| 2 | +
|
| 3 | +Providers enforce ``^[A-Za-z0-9_-]{1,64}$`` on ``tools[].function.name``, so a |
| 4 | +dotted MCP name such as ``browser.fetch`` is sanitized on the way to the model |
| 5 | +and mapped back to the server's own name when the call comes back. |
| 6 | +""" |
| 7 | + |
| 8 | +from types import SimpleNamespace |
| 9 | +from unittest.mock import AsyncMock, MagicMock |
| 10 | + |
| 11 | +import pytest |
| 12 | + |
| 13 | +from cecli.coders import Coder |
| 14 | +from cecli.helpers import responses |
| 15 | + |
| 16 | + |
| 17 | +def _tool(name): |
| 18 | + """Build a minimal OpenAI-style function tool dict.""" |
| 19 | + return { |
| 20 | + "type": "function", |
| 21 | + "function": {"name": name, "description": "", "parameters": {}}, |
| 22 | + } |
| 23 | + |
| 24 | + |
| 25 | +def _call(name): |
| 26 | + return { |
| 27 | + "id": "call-1", |
| 28 | + "type": "function", |
| 29 | + "function": {"name": name, "arguments": "{}"}, |
| 30 | + } |
| 31 | + |
| 32 | + |
| 33 | +class TestSanitizeToolName: |
| 34 | + def test_dots_become_underscores(self): |
| 35 | + assert responses.sanitize_tool_name("browser.fetch") == "browser_fetch" |
| 36 | + |
| 37 | + def test_is_idempotent(self): |
| 38 | + once = responses.sanitize_tool_name("browser.persisted_session.list") |
| 39 | + |
| 40 | + assert responses.sanitize_tool_name(once) == once |
| 41 | + |
| 42 | + def test_honors_provider_length_limit(self): |
| 43 | + assert len(responses.sanitize_tool_name("a" * 200)) == 64 |
| 44 | + |
| 45 | + |
| 46 | +class TestGetToolListSanitizesNames: |
| 47 | + def _coder(self, tools): |
| 48 | + return SimpleNamespace( |
| 49 | + mcp_tools=[("browser", tools)], |
| 50 | + registered_servers={"included": set(), "excluded": set()}, |
| 51 | + registered_tools={"included": set(), "excluded": set()}, |
| 52 | + ) |
| 53 | + |
| 54 | + def test_dotted_names_are_sanitized_for_the_model(self): |
| 55 | + coder = self._coder([_tool("browser.fetch"), _tool("browser.persisted_session.list")]) |
| 56 | + |
| 57 | + names = [t["function"]["name"] for t in Coder.get_tool_list(coder)] |
| 58 | + |
| 59 | + assert names == [ |
| 60 | + "browser--browser_fetch", |
| 61 | + "browser--browser_persisted_session_list", |
| 62 | + ] |
| 63 | + |
| 64 | + def test_underscore_name_is_unchanged(self): |
| 65 | + coder = self._coder([_tool("brave_web_search")]) |
| 66 | + |
| 67 | + names = [t["function"]["name"] for t in Coder.get_tool_list(coder)] |
| 68 | + |
| 69 | + assert names == ["browser--brave_web_search"] |
| 70 | + |
| 71 | + |
| 72 | +class TestFindMcpServerForSanitizedCall: |
| 73 | + def test_sanitized_call_resolves_to_its_server(self): |
| 74 | + server = SimpleNamespace(name="browser") |
| 75 | + coder = SimpleNamespace( |
| 76 | + mcp_tools=[("browser", [_tool("browser.fetch")])], |
| 77 | + mcp_manager=[server], |
| 78 | + ) |
| 79 | + tool_call = SimpleNamespace( |
| 80 | + id="call-1", |
| 81 | + type="function", |
| 82 | + function=SimpleNamespace(name="browser--browser_fetch"), |
| 83 | + ) |
| 84 | + |
| 85 | + assert Coder._find_mcp_server_for_tool(coder, tool_call) is server |
| 86 | + |
| 87 | + |
| 88 | +class TestCallToolMapsBackToAdvertisedName: |
| 89 | + """The name the model calls must reach the server unsanitized.""" |
| 90 | + |
| 91 | + @pytest.mark.asyncio |
| 92 | + async def test_sanitized_name_is_mapped_back(self): |
| 93 | + coder = SimpleNamespace(mcp_tools=[("browser", [_tool("browser.fetch")])]) |
| 94 | + session = MagicMock() |
| 95 | + session.call_tool = AsyncMock(return_value="ok") |
| 96 | + |
| 97 | + await Coder.call_mcp_tool_from_session(coder, session, _call("browser_fetch")) |
| 98 | + |
| 99 | + assert session.call_tool.await_args.kwargs["name"] == "browser.fetch" |
| 100 | + |
| 101 | + @pytest.mark.asyncio |
| 102 | + async def test_unsanitized_name_passes_through(self): |
| 103 | + coder = SimpleNamespace(mcp_tools=[("browser", [_tool("browser.fetch")])]) |
| 104 | + session = MagicMock() |
| 105 | + session.call_tool = AsyncMock(return_value="ok") |
| 106 | + |
| 107 | + await Coder.call_mcp_tool_from_session(coder, session, _call("browser.fetch")) |
| 108 | + |
| 109 | + assert session.call_tool.await_args.kwargs["name"] == "browser.fetch" |
| 110 | + |
| 111 | + @pytest.mark.asyncio |
| 112 | + async def test_unknown_name_is_not_rewritten(self): |
| 113 | + coder = SimpleNamespace(mcp_tools=[("browser", [_tool("browser.fetch")])]) |
| 114 | + session = MagicMock() |
| 115 | + session.call_tool = AsyncMock(return_value="ok") |
| 116 | + |
| 117 | + await Coder.call_mcp_tool_from_session(coder, session, _call("read_file")) |
| 118 | + |
| 119 | + assert session.call_tool.await_args.kwargs["name"] == "read_file" |
0 commit comments