Skip to content

Reset the cached encoder when encoding changes #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reset the cached encoder when encoding changes #510

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
798ed26
Reset cached encoder when encoding changes
OskarEichler Aug 30, 2026
e301da9
Apply attr reader review feedback
OskarEichler Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/webauthn/relying_party.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ def initialize(
end

attr_accessor :algorithms,
:encoding,
:allowed_origins,
:allowed_top_origins,
:id,
Expand All @@ -60,6 +59,8 @@ def initialize(
:acceptable_attestation_types,
:legacy_u2f_appid

attr_reader :encoding

@santiagorodriguez96 santiagorodriguez96 Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this to the attr_reader in line 64:

https://github.com/OskarEichler/webauthn-ruby/blob/798ed267e052a09fddab705cf91f5bc2f1a2dccf/lib/webauthn/relying_party.rb#L64


attr_reader :attestation_root_certificates_finders

# This is the user-data encoder.
Expand All @@ -68,6 +69,13 @@ def encoder
@encoder ||= WebAuthn::Encoder.new(encoding)
end

attr_writer :encoder

@santiagorodriguez96 santiagorodriguez96 Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?


def encoding=(encoding)
@encoding = encoding
@encoder = nil
end

def attestation_root_certificates_finders=(finders)
if !finders.respond_to?(:each)
finders = [finders]
Expand Down
Loading