Two hygiene problems on the reconverse-specific-build branch, noted while working at tip 90ef159 (now cdaf6a4):
-
Classic arches no longer build from this branch. ./build charm++ netlrts-darwin-arm8 smp installs reconverse's include/converse.h into the netlrts build dir, so ck-core fails at init.C:1669 with _Cmi_sleepOnIdle / _Cmi_forceSpinOnIdle undeclared. If classic builds from this branch are meant to work, the header install selection needs an arch guard.
-
examples/charm++/hello/1darray/hello.C carries committed debug hackery from 9e48ce9 ("merge reconverse changes with lb"): CkExit() inside the Hello constructor and setInitCallback commented out. The example prints "Hello 0 created" and silently exits 0, which masquerades as a runtime failure to anyone using it as a smoke test. Should be reverted to the mainline version.
(Context: the branch is the reconverse development line, so item 1 may be tolerated deliberately — filing so the state is recorded.)
Two hygiene problems on the
reconverse-specific-buildbranch, noted while working at tip 90ef159 (now cdaf6a4):Classic arches no longer build from this branch.
./build charm++ netlrts-darwin-arm8 smpinstalls reconverse'sinclude/converse.hinto the netlrts build dir, so ck-core fails atinit.C:1669with_Cmi_sleepOnIdle/_Cmi_forceSpinOnIdleundeclared. If classic builds from this branch are meant to work, the header install selection needs an arch guard.examples/charm++/hello/1darray/hello.Ccarries committed debug hackery from 9e48ce9 ("merge reconverse changes with lb"):CkExit()inside the Hello constructor andsetInitCallbackcommented out. The example prints "Hello 0 created" and silently exits 0, which masquerades as a runtime failure to anyone using it as a smoke test. Should be reverted to the mainline version.(Context: the branch is the reconverse development line, so item 1 may be tolerated deliberately — filing so the state is recorded.)