Skip to content

One tree for both runtimes: classic arches to be served by main + reconverse glue, not by resurrecting classic in the branch #3941

Description

@lvkale

Two hygiene problems on the reconverse-specific-build branch, noted while working at tip 90ef159 (now cdaf6a4):

  1. Classic arches no longer build from this branch. ./build charm++ netlrts-darwin-arm8 smp installs reconverse's include/converse.h into the netlrts build dir, so ck-core fails at init.C:1669 with _Cmi_sleepOnIdle / _Cmi_forceSpinOnIdle undeclared. If classic builds from this branch are meant to work, the header install selection needs an arch guard.

  2. examples/charm++/hello/1darray/hello.C carries committed debug hackery from 9e48ce9 ("merge reconverse changes with lb"): CkExit() inside the Hello constructor and setInitCallback commented out. The example prints "Hello 0 created" and silently exits 0, which masquerades as a runtime failure to anyone using it as a smoke test. Should be reverted to the mainline version.

(Context: the branch is the reconverse development line, so item 1 may be tolerated deliberately — filing so the state is recorded.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions