Skip to content

build(deps)!: upgrade coordinated DOM dependencies - #1210

Merged
fb55 merged 4 commits into
masterfrom
dependabot/npm_and_yarn/htmlparser2-12.0.0
Oct 10, 2026
Merged

fb55 merged 4 commits into
masterfrom
dependabot/npm_and_yarn/htmlparser2-12.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Mar 23, 2026 •

Copy link
Copy Markdown
Contributor

The DOM dependencies now use boolbase 2, css-select 7, css-what 8, domhandler 6, domutils 4 and htmlparser2 12 together, with a Dependabot group for future updates. cheerio-select uses css-select’s exported _compileUnsafe entry point and domhandler’s isTag, and its test helpers use parseDocument and ESM fixture paths.

CommonJS and ESM package exports are retained.

Breaking changes: Removes the exported aliases, filters and pseudos extension tables, and requires Node >=20.19.0. Custom pseudo definitions can use the existing options.pseudos API. This change requires a major release.

Validation: clean dependency install; CJS and ESM builds; test type check; lint; all 46 tests and 3 snapshots on Node 20.19.0; both package export formats and positional selectors verified on the same minimum; changed workflow actionlint passes.

Combines css-select, domutils, domhandler, css-what and boolbase. TypeScript and TypeDoc stay independently updated.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [htmlparser2](https://github.com/fb55/htmlparser2) from 10.1.0 to 12.0.0.
- [Release notes](https://github.com/fb55/htmlparser2/releases)
- [Commits](fb55/htmlparser2@v10.1.0...v12.0.0)

---
updated-dependencies:
- dependency-name: htmlparser2
  dependency-version: 12.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 23f49270-e2ba-40e4-b14e-fae0e9010b4f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fb55

fb55 commented Oct 9, 2026

Copy link
Copy Markdown
Member

@coderabbitai review

@fb55
fb55 requested a balanced review from Copilot October 9, 2026 19:00
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review skipped.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The CommonJS export becomes unusable with ESM-only dependencies, and public extension exports are removed without a major-version plan.

3 open findings
What changed in this PR

Upgrades the HTML parsing/DOM dependency stack to ESM-only major versions and raises the minimum Node.js version.

Changes:

  • Upgrades htmlparser2 and related DOM dependencies.
  • Adapts source and tests to updated APIs and ESM execution.
  • Updates CI and Dependabot configuration.
File Description
package.json Updates dependencies, Jest ESM configuration, and Node requirement.
package-lock.json Locks upgraded dependency graph.
src/​index.ts Adapts css-select and domhandler APIs.
test/​sizzle.spec.ts Migrates parsing helpers to parseDocument.
test/​tools/​sizzle-testinit.ts Updates ESM fixture loading and DOM APIs.
.github/​workflows/​nodejs-test.yml Tests supported Node versions.
.github/​dependabot.yml Groups related DOM dependencies.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
Comment thread src/index.ts
Comment thread package.json
@fb55 fb55 changed the title chore(deps-dev): Bump htmlparser2 from 10.1.0 to 12.0.0 build(deps)!: upgrade coordinated DOM dependencies Oct 9, 2026
@fb55
fb55 merged commit 7869e11 into master Oct 10, 2026
9 checks passed
@fb55
fb55 deleted the dependabot/npm_and_yarn/htmlparser2-12.0.0 branch October 10, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants