Fix custom Geo resource URLs - #2226
Open
imzihuailin wants to merge 1 commit into
Open
Conversation
Author
|
Additional manual validation completed:
One separate startup-timing behavior remains out of scope for this PR: if the Geo files are deleted immediately before an app restart, startup can recreate the defaults before the scheduled custom updater runs. The explicit updater path itself consumed both corrected custom URL fields successfully. |
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geo-ip/geo-sitetogeoip/geositeImpact
The field-name regression caused custom GEOIP and GEOSITE URLs to be written under keys Mihomo does not consume, so first-time Geo resource downloads could fall back to the default URLs instead of using the user's configured sources. This change restores the expected keys without changing MMDB or ASN handling.
This PR is intentionally limited to the custom Geo URL mapping and does not change the startup-stage Geo auto-update flow.
Validation
dart format lib/enum/enum.dart test/models/config_test.dartflutter analyze --no-fatal-infos(passes with 10 pre-existingwithOpacityinfo diagnostics)flutter test test/models/config_test.dart(33 tests passed)flutter test --reporter expanded(417 tests passed)Fixes #2215