fix: omit inactive TUN IPv6 from generated config - #2238
Open
paiwoo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Rationale
Mihomo clears this address later while parsing a runtime config, but FlClash first round-trips the raw config and writes it back to YAML. Returning the inactive default at that stage produces a contradictory generated configuration: ipv6 is false while a TUN IPv6 address is present.
Verification
The focused test is included in core/hub_test.go. The root project does not contain a Go module, so the project build workflow or CI must execute it rather than go test ./core directly.