kubevirt: proxmoxve: Use ip=any rather than ip=dhcp,dhcp6 for dual stack

systemd-network-generator does not support multiple autoconf values, and
fixing this appears difficult. Even then, Dracut does not treat
`dhcp,dhcp6` in quite the same way that systemd and NetworkManager do.
It only tries IPv6 if IPv4 fails.

As of Dracut 112, `any` is treated as IPv4-only, despite the name.
However, I have submitted dracut-ng/dracut#2628
to change this behaviour so that it is dual stack in the same manner as
systemd and NetworkManager.

This would break Afterburn consumers relying on Dracut's network-legacy
in the meantime. However, FCOS has already migrated to NetworkManager,
and Flatcar is now migrating to systemd-network-manager. I'm not aware
of any other consumers.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>

Author: chewi

docs/release-notes.md

@@ -27,6 +27,7 @@ Minor changes:
 - ProxmoxVE: Emit one `nameserver=` karg per address so multiple DNS servers work
 - ProxmoxVE: Prevent rd-network-kargs from failing without a config drive
 - KubeVirt: Use `off` rather than `static` to disable IP autoconf for Dracut and systemd compatibility
+- KubeVirt and ProxmoxVE: Use `ip=any` rather than `ip=dhcp,dhcp6` for Dracut and systemd compatibility
 
 Packaging changes:
 

src/providers/kubevirt/cloudconfig.rs

@@ -211,7 +211,7 @@ impl MetadataProvider for KubeVirtCloudConfig {
                 match dhcp {
                     DhcpSetting::V4 => kargs.push(format!("ip={}:dhcp", id)),
                     DhcpSetting::V6 => kargs.push(format!("ip={}:dhcp6", id)),
-                    DhcpSetting::Both => kargs.push(format!("ip={}:dhcp,dhcp6", id)),
+                    DhcpSetting::Both => kargs.push(format!("ip={}:any", id)),
                 }
             }
 

src/providers/kubevirt/tests.rs

@@ -207,7 +207,7 @@ fn test_network_data() {
         let expected = [
             "ip=192.168.1.10:::255.255.255.0::eth0:off",
             "ip=[2001:db8::10]:::64::eth0:off",
-            "ip=eth1:dhcp,dhcp6",
+            "ip=eth1:any",
             "rd.route=0.0.0.0/0:192.168.1.1",
             "rd.route=[::/0]:[2001:db8::1]",
             "nameserver=8.8.8.8",
@@ -292,7 +292,7 @@ fn assert_dhcp_with_static_gw_and_dns(config: &KubeVirtCloudConfig) {
     );
 
     let expected = [
-        "ip=eth0:dhcp,dhcp6",
+        "ip=eth0:any",
         "rd.route=0.0.0.0/0:192.168.1.1",
         "rd.route=[::/0]:[2001:db8::1]",
         "nameserver=8.8.8.8",
@@ -361,7 +361,7 @@ fn assert_no_duplicate_routes(config: &KubeVirtCloudConfig) {
 
     let kargs = config.rd_network_kargs().unwrap().unwrap();
     let expected = [
-        "ip=eth0:dhcp,dhcp6",
+        "ip=eth0:any",
         "rd.route=0.0.0.0/0:192.168.1.1",
         "rd.route=[::/0]:[2001:db8::1]",
     ];

src/providers/proxmoxve/cloudconfig.rs

@@ -241,7 +241,7 @@ impl MetadataProvider for ProxmoxVECloudConfig {
                     match dhcp {
                         DhcpSetting::V4 => kargs.push("ip=dhcp".to_string()),
                         DhcpSetting::V6 => kargs.push("ip=dhcp6".to_string()),
-                        DhcpSetting::Both => kargs.push("ip=dhcp,dhcp6".to_string()),
+                        DhcpSetting::Both => kargs.push("ip=any".to_string()),
                     }
                 }