Skip to content

Commit 9afe464

Browse files
Update chive-scopes tests to expect include scopes without aud qualifier after switching rpc permissions to aud wildcard
1 parent 8870cf1 commit 9afe464

1 file changed

Lines changed: 10 additions & 18 deletions

File tree

tests/unit/auth/scopes/chive-scopes.test.ts

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -114,23 +114,15 @@ describe('chive-scopes', () => {
114114
});
115115

116116
describe('PERMISSION_SETS', () => {
117-
it('defines four permission set references with the Chive service DID as audience', () => {
118-
// Each `include:` carries `?aud=did:web:chive.pub` so that rpc
119-
// permissions inside the set (which all set `inheritAud: true`)
120-
// inherit the Chive service DID as audience -- the PDS can then
121-
// mint service-auth JWTs whose `aud` matches what the API expects.
122-
expect(PERMISSION_SETS.BASIC_READER).toBe(
123-
'include:pub.chive.basicReader?aud=did:web:chive.pub'
124-
);
125-
expect(PERMISSION_SETS.AUTHOR_ACCESS).toBe(
126-
'include:pub.chive.authorAccess?aud=did:web:chive.pub'
127-
);
128-
expect(PERMISSION_SETS.REVIEWER_ACCESS).toBe(
129-
'include:pub.chive.reviewerAccess?aud=did:web:chive.pub'
130-
);
131-
expect(PERMISSION_SETS.FULL_ACCESS).toBe(
132-
'include:pub.chive.fullAccess?aud=did:web:chive.pub'
133-
);
117+
it('defines four permission set references without audience qualifiers', () => {
118+
// The `?aud=` qualifier on `include:` was dropped because the rpc
119+
// permissions inside the lexicons declare `aud: "*"` directly, and
120+
// `IncludeScope` rejects an aud without `#fragment` per
121+
// `@atproto/did.isAtprotoAudience`.
122+
expect(PERMISSION_SETS.BASIC_READER).toBe('include:pub.chive.basicReader');
123+
expect(PERMISSION_SETS.AUTHOR_ACCESS).toBe('include:pub.chive.authorAccess');
124+
expect(PERMISSION_SETS.REVIEWER_ACCESS).toBe('include:pub.chive.reviewerAccess');
125+
expect(PERMISSION_SETS.FULL_ACCESS).toBe('include:pub.chive.fullAccess');
134126
});
135127

136128
it('prefixes all sets with include:', () => {
@@ -179,7 +171,7 @@ describe('chive-scopes', () => {
179171
const parts = result.split(' ');
180172
expect(parts).toContain('atproto');
181173
expect(parts).toContain('transition:generic');
182-
expect(parts).toContain('include:pub.chive.fullAccess?aud=did:web:chive.pub');
174+
expect(parts).toContain('include:pub.chive.fullAccess');
183175
});
184176

185177
it('deduplicates atproto if passed explicitly', () => {

0 commit comments

Comments
 (0)