Give the new Semble index tables the staleness column every index table carries

Author: aaronstevenwhite

src/services/collection/collection-service.ts

@@ -2327,14 +2327,15 @@ export class CollectionService {
       await this.pool.query(
         `INSERT INTO cosmik_collections_index (
           uri, cid, owner_did, name, description, access_type, created_at,
-          pds_url, indexed_at, updated_at
-        ) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, NOW(), NOW())
+          pds_url, indexed_at, updated_at, last_synced_at
+        ) VALUES ($1, $2, $3, $4, $5, $6, $7, $8, NOW(), NOW(), NOW())
         ON CONFLICT (uri) DO UPDATE SET
           cid = EXCLUDED.cid,
           name = EXCLUDED.name,
           description = EXCLUDED.description,
           access_type = EXCLUDED.access_type,
-          updated_at = NOW()`,
+          updated_at = NOW(),
+          last_synced_at = NOW()`,
         [
           metadata.uri,
           metadata.cid,
@@ -2407,19 +2408,20 @@ export class CollectionService {
       await this.pool.query(
         `INSERT INTO cosmik_collection_links_index (
           uri, cid, owner_did, card_uri, collection_uri, added_by, added_at,
-          is_removed, pds_url, indexed_at, updated_at
+          is_removed, pds_url, indexed_at, updated_at, last_synced_at
         ) VALUES (
           $1, $2, $3, $4, $5, $6, $7,
           COALESCE((SELECT is_removed FROM cosmik_collection_links_index WHERE uri = $1), false),
-          $8, NOW(), NOW()
+          $8, NOW(), NOW(), NOW()
         )
         ON CONFLICT (uri) DO UPDATE SET
           cid = EXCLUDED.cid,
           card_uri = EXCLUDED.card_uri,
           collection_uri = EXCLUDED.collection_uri,
           added_by = EXCLUDED.added_by,
           added_at = EXCLUDED.added_at,
-          updated_at = NOW()`,
+          updated_at = NOW(),
+          last_synced_at = NOW()`,
         [
           metadata.uri,
           metadata.cid,

src/storage/postgresql/migrations/1743300000000_cosmik-collection-links.ts

@@ -47,6 +47,10 @@ export function up(pgm: MigrationBuilder): void {
     pds_url: { type: 'text' },
     indexed_at: { type: 'timestamptz', notNull: true, default: pgm.func('NOW()') },
     updated_at: { type: 'timestamptz', notNull: true, default: pgm.func('NOW()') },
+    // Every `*_index` table carries this: it is how a row's staleness against
+    // the repository it came from is judged, and the compliance suite asserts
+    // that none is missing it.
+    last_synced_at: { type: 'timestamptz', notNull: true, default: pgm.func('NOW()') },
   });
 
   pgm.createIndex('cosmik_collections_index', 'owner_did');
@@ -71,6 +75,7 @@ export function up(pgm: MigrationBuilder): void {
     pds_url: { type: 'text' },
     indexed_at: { type: 'timestamptz', notNull: true, default: pgm.func('NOW()') },
     updated_at: { type: 'timestamptz', notNull: true, default: pgm.func('NOW()') },
+    last_synced_at: { type: 'timestamptz', notNull: true, default: pgm.func('NOW()') },
   });
 
   // The read path asks "which collection is this card in", once per Semble

tests/compliance/database-compliance.test.ts

@@ -601,12 +601,12 @@ describe('ATProto Database Compliance', () => {
         {
           name: 'Index semantics (_index naming)',
           query: `SELECT COUNT(*) as count FROM information_schema.tables WHERE table_schema = 'public' AND table_name LIKE '%_index'`,
-          expected: 25, // eprints, reviews, endorsements, user_tags, relevance_logs, activity_log, authors, coauthor_claims, changelogs, annotations, entity_links, user_related_works, personal_graph_nodes, personal_graph_edges, collections, collection_edges, eprint_versions, cosmik_connections, cosmik_follows, margin_annotations, margin_bookmarks, cosmik_link_removals, collaboration_invites, collaboration_acceptances, muted_authors
+          expected: 27, // eprints, reviews, endorsements, user_tags, relevance_logs, activity_log, authors, coauthor_claims, changelogs, annotations, entity_links, user_related_works, personal_graph_nodes, personal_graph_edges, collections, collection_edges, eprint_versions, cosmik_connections, cosmik_follows, cosmik_collections, cosmik_collection_links, margin_annotations, margin_bookmarks, cosmik_link_removals, collaboration_invites, collaboration_acceptances, muted_authors
         },
         {
           name: 'PDS source tracking',
           query: `SELECT COUNT(*) as count FROM information_schema.columns WHERE table_schema = 'public' AND table_name LIKE '%_index' AND column_name = 'pds_url'`,
-          expected: 25, // All index tables have pds_url
+          expected: 27, // All index tables have pds_url
         },
         {
           name: 'No blob data',