Release 0.22.2 - #208
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three faults in the citation network, reported on the deployed 0.22.1.
Arrows ran through the papers and overshot them. The cause was routing, not stacking. React Flow routes an edge between handles, and a handle is fixed to one side of its node — my target handle sat at the top, so an edge whose cited paper was above its citing one had to travel up through that paper's body to reach its top edge. That put the line across the pill and the arrowhead inside it. Edges now compute their own endpoints from the two node outlines, meeting whichever point faces the other node. The
zIndexchange in 0.22.1 treated a symptom of this and did not fix it; thatzIndexis gone.The line showed through the arrowhead. The fade was element
opacity, which applies to the path and the marker alike, so the two composited where they overlap. The fade lives in the stroke colour now and the arrowhead takes exactly that colour.Papers beyond one citation were labelled. This was in the original brief and I missed it. A paper more than one citation from the focus or the current selection is drawn as a 12px dot with no text; it grows into a labelled pill the moment it attaches to either. Hovering still names any paper in full.
Related Issues
None.
Type of Change
How Has This Been Tested?
Verified in a browser against live production data before deploying, by measurement rather than by eye — the previous attempt was signed off on a screenshot I read wrongly.
Programmatic checks on the rendered graph, both with and without a paper selected:
elementFromPoint— 72 crossings, node painted on top in all of them, edge in none.Unit coverage: 13 new geometry tests, including that an endpoint always lands on the outline and never inside it, and that a sampled segment between two papers enters neither. Plus tests that no edge sets
opacity, that every arrowhead matches its line's colour, that every edge uses the floating type, and that a background node renders no text.Full frontend suite 3015 green.
pnpm typecheck(both projects),pnpm format:check,pnpm lint(0 errors) and the OpenAPI check all clean.Screenshots
Compared against the reported view at the same zoom and the same selected node.
Checklist
General
npm run lintpasses)npm test)ATProto Compliance (required for data flow changes)
npm run test:compliance— 100% required)Presentation only; no data flow touched.
Breaking Changes