Expose initial state in head - #446
Open
tornqvist wants to merge 1 commit into
Open
Conversation
goto-bus-stop
approved these changes
Mar 9, 2018
goto-bus-stop
left a comment
Member
There was a problem hiding this comment.
seems good! should we wait for the choo PR to land then?
Member
|
@tornqvist didn't you mean to reference choojs/choo#638 instead of the components PR. If so, that's been merged and published already! |
Member
Author
|
@yoshuawuyts naw, choojs/choo#638 only added lazy stores but never forwarded the new state when reinitializing them on |
Member
|
@tornqvist ah alright, makes sense! |
tornqvist
force-pushed
the
expose-initial-state
branch
from
March 22, 2018 12:34
ea5cc03 to
ac92c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a 🙋 feature
With the support for Choo SSR using the
_experimental_prefetchit would make sense to expose the generated initial state on the window for the client to pick up.Idk if this is too choo specific to include in the default document but from what I could find no other framework has an official specific key under which to expose the initial state.
Checklist
Context
This is in part dependent on choojs/choo#639 which ensures a clean state on every call to
toString.Semver Changes
Minor