Skip to content

Commit f35e518

Browse files
Merge pull request #336 from choosehappy/upgrade-openslide
Upgrade openslide to 4.0
2 parents 30d2f65 + 8d9a30b commit f35e518

3 files changed

Lines changed: 18 additions & 8 deletions

File tree

‎.devcontainer/devcontainer.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"name": "HistoQC Development Container",
3+
"build": {
4+
"dockerfile": "../Dockerfile",
5+
"context": ".."
6+
},
7+
"workspaceFolder": "/opt/HistoQC",
8+
"workspaceMount": "source=${localWorkspaceFolder},target=/opt/HistoQC,type=bind",
9+
"remoteUser": "root",
10+
"postCreateCommand": "python -m venv venv && venv/bin/pip install --no-cache-dir -e . && apt update && apt install -y git"
11+
}

‎Dockerfile‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# the python environment are copied over. We do not require a C compiler in the second
66
# stage, and so we can use a slimmer base image.
77

8-
FROM python:3.8 AS builder
8+
FROM python:3.10 AS builder
99
ARG DEBIAN_FRONTEND=noninteractive
1010
WORKDIR /opt/HistoQC
1111
COPY . .
@@ -14,15 +14,13 @@ COPY . .
1414
ENV PATH="/opt/HistoQC/venv/bin:$PATH"
1515
RUN python -m venv venv \
1616
&& python -m pip install --no-cache-dir setuptools wheel \
17-
&& python -m pip install --no-cache-dir . \
18-
# We force this so there is no error even if the dll does not exist.
19-
&& rm -f libopenslide-0.dll
17+
&& python -m pip install --no-cache-dir .
2018

21-
FROM python:3.8-slim
19+
20+
FROM python:3.10-slim
2221
ARG DEBIAN_FRONTEND=noninteractive
2322
RUN apt-get update \
2423
&& apt-get install -y --no-install-recommends \
25-
libopenslide0 \
2624
libtk8.6 \
2725
procps \
2826
&& rm -rf /var/lib/apt/lists/*

‎pyproject.toml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,10 @@ classifiers = [
2626
"Operating System :: Unix"
2727
]
2828

29-
requires-python = ">=3.8"
29+
requires-python = ">=3.10"
3030
dependencies = [
31-
"openslide-python==1.1.2",
31+
"openslide-bin==4.0.1.2",
32+
"openslide-python==1.4.6",
3233
"scikit-image~=0.19.2",
3334
"scikit-learn~=1.2.1",
3435
"numpy~=1.23.5",

0 commit comments

Comments
 (0)