Repository navigation
Commit ea4c90a
committed
fix(stack-encrypt): address the review of hiding ExpectedContext
The previous commit put #[doc(hidden)] on the re-export of
ExpectedContext only. rustc and rustdoc read the attribute on the
definition, so two things still showed the type:
- rustc listed ExpectedContext<T> among the implementors of
AllowsNoContext and AcceptsContext in every E0277 a caller gets for a
wrong context.
- rustdoc for crates that name the type (eql-bindings, and any crate
using the derives with a context field) linked it to a page that is
never generated. On docs.rs that is a 404 on about 50 EQL type pages.
The attribute is now on the struct as well. Six trybuild snapshots lose
the ExpectedContext<T> lines. In eql-bindings' docs the type name is
now plain text.
Also:
- eql-bindings: the JsonTreeDocument DecryptInto impl no longer links to
the hidden type. Its doc says what the caller passes. The impl itself
is unchanged, so eql-bindings' API is the same.
- CHANGELOG: the upgrade note used T for both the context type and the
plaintext type. It now names them C and P, says that code naming the
type still compiles but is outside semver, names decrypt_from for no
check, and says eql-bindings also names the type.
- tests/derive_plan.rs: the empty stored context test now checks that
the error is the empty-context refusal, not just any error.
- ADR-0012, the API plan and attributes.md no longer say the type is
public, or that the whole plan item is done.1 parent 6516dc1 commit ea4c90a
14 files changed
Lines changed: 39 additions & 57 deletions
File tree
- docs/plans
- packages
- eql/crates/eql-bindings/src/v4
- stack-encrypt-derive/docs
- stack-encrypt
- docs/adr
- src/target
- tests
- ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1739 | 1739 | | |
1740 | 1740 | | |
1741 | 1741 | | |
1742 | | - | |
1743 | | - | |
1744 | | - | |
1745 | | - | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
1746 | 1747 | | |
1747 | 1748 | | |
1748 | 1749 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
514 | 514 | | |
515 | 515 | | |
516 | 516 | | |
517 | | - | |
518 | | - | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
519 | 521 | | |
520 | 522 | | |
521 | 523 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | | - | |
| 105 | + | |
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
101 | 106 | | |
102 | 107 | | |
103 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
265 | 265 | | |
266 | 266 | | |
267 | 267 | | |
268 | | - | |
269 | | - | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
270 | 272 | | |
271 | 273 | | |
272 | 274 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
914 | 914 | | |
915 | 915 | | |
916 | 916 | | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
917 | 922 | | |
918 | 923 | | |
919 | 924 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | | - | |
| 190 | + | |
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
745 | 746 | | |
746 | 747 | | |
747 | 748 | | |
748 | | - | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
749 | 755 | | |
750 | 756 | | |
751 | 757 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | 20 | | |
24 | 21 | | |
25 | 22 | | |
| |||
48 | 45 | | |
49 | 46 | | |
50 | 47 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 48 | | |
55 | 49 | | |
56 | 50 | | |
| |||
74 | 68 | | |
75 | 69 | | |
76 | 70 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | 71 | | |
81 | 72 | | |
82 | 73 | | |
| |||
94 | 85 | | |
95 | 86 | | |
96 | 87 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | 88 | | |
101 | 89 | | |
102 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | 18 | | |
22 | 19 | | |
23 | 20 | | |
| |||
46 | 43 | | |
47 | 44 | | |
48 | 45 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | 46 | | |
53 | 47 | | |
54 | 48 | | |
| |||
0 commit comments