fix: remove runtime FFmpeg installation

Author: sam0rr

README.md

@@ -135,6 +135,8 @@ Core technologies include:
 
 Since ClefinCode Chat is a Frappe app, it can be installed via [frappe-bench](https://frappeframework.com/docs/v14/user/en/bench) on a local machine or production site.
 
+FFmpeg must be installed on the server for audio and video processing. For Docker deployments, include it when building the image. The app installer does not install system packages or require `sudo`.
+
 ```bash
 bench get-app https://github.com/clefincode/clefincode_chat.git
 bench --site yoursite.name install-app clefincode_chat

clefincode_chat/setup/install.py

@@ -1,5 +1,4 @@
 import frappe
-import subprocess
 
 def ensure_contact_custom_fields():
     from frappe.custom.doctype.custom_field.custom_field import create_custom_field
@@ -17,7 +16,6 @@ def after_install():
     ensure_contact_custom_fields()
     create_roles()   
     create_users_profiles()
-    install_ffmpeg()
     add_default_limited_roles()
 # =================================================================================
 def create_roles():
@@ -101,14 +99,6 @@ def create_users_profiles():
 
     frappe.db.commit()       
 # =================================================================================
-def install_ffmpeg():
-    try:
-        subprocess.run(["sudo", "apt", "update", "--fix-missing" , "-y",], check=True)
-        subprocess.run(["sudo", "apt", "install", "ffmpeg", "--fix-missing" , "-y"], check=True)
-    except subprocess.CalledProcessError as e:
-        print(f"An error occurred: {e}")
-# =================================================================================
-
 def add_default_limited_roles():
     """Add default roles without removing or duplicating existing roles."""
     DEFAULT_LIMITED_ROLES =  ["Customer", "Supplier", "Student", "Instructor", "Sales Partner", "Member", "Shareholder", "Guardian"]
@@ -138,4 +128,4 @@ def add_default_limited_roles():
         changed = True
 
     if changed:
-        settings.save(ignore_permissions=True)
+        settings.save(ignore_permissions=True)

clefincode_chat/setup/test_install.py

@@ -0,0 +1,28 @@
+from contextlib import ExitStack
+from unittest import TestCase
+from unittest.mock import patch
+
+from clefincode_chat.setup import install
+
+
+class TestAfterInstall(TestCase):
+    def test_initializes_app_without_installing_system_packages(self):
+        helpers = (
+            "ensure_contact_custom_fields",
+            "create_roles",
+            "create_users_profiles",
+            "add_default_limited_roles",
+        )
+        with ExitStack() as stack:
+            setup_steps = [
+                stack.enter_context(patch.object(install, name)) for name in helpers
+            ]
+            run = stack.enter_context(
+                patch("subprocess.run", side_effect=PermissionError("No sudo access"))
+            )
+
+            install.after_install()
+
+            run.assert_not_called()
+            for step in setup_steps:
+                step.assert_called_once_with()