Conversation
sam0rr
changed the title
sam0rr
force-pushed
the
fix_ffmpeg_installation
branch
from
September 14, 2026 01:16
4e6e720 to
60fc255
Compare
sam0rr
force-pushed
the
fix_ffmpeg_installation
branch
from
September 14, 2026 01:25
60fc255 to
645c5ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing Chat currently runs
sudo apt, even when FFmpeg is already available. This assumes elevated privileges and an APT-based system, and can interrupt installation in production containers.Check for the executable instead. If it is missing, print a warning asking the administrator to install it manually, then continue the remaining setup steps. System packages belong in server or image provisioning, using the appropriate package manager.
This follows the removal of runtime FFmpeg installation and the FFmpeg APT dependency declaration already in
develop-marketplace. The dependency declaration installs FFmpeg on Frappe Cloud; other deployments supply it themselves.Verified on Python 3.14.7 and Frappe 16.33.1 that missing FFmpeg prints the warning and all remaining setup steps complete. When FFmpeg is present, the check stays silent. Neither path invokes a subprocess.