Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploading a file from the portal can fail with a permission error for
ClefinCode Chat Message. The upload request uses the conversation ID as the message ID, even though the message has not been created yet.Remove those two attachment fields from the initial upload. Frappe creates the file for the signed-in user, and the existing send flow links it to the actual message using the returned file ID.
Reproduced the failure and checked the corrected upload and message linkage with a Website User and a staff user on Frappe 16.33.1 and MariaDB 11.8.6. Also checked that the JavaScript still passes the returned file ID to the message sender. Existing file visibility settings are unchanged.